Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: src/code-events.h

Issue 2753543006: [profiler] Web UI: add summary of opts/deopts. (Closed)
Patch Set: Tweaks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | src/deoptimizer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-events.h
diff --git a/src/code-events.h b/src/code-events.h
index db43d88b681a12dc04c95c1d37bbb7c51b11b0d4..f27d45cc302dc78a6ac9917bff5e647f23f02df7 100644
--- a/src/code-events.h
+++ b/src/code-events.h
@@ -105,7 +105,9 @@ class CodeEventListener {
virtual void CodeMovingGCEvent() = 0;
virtual void CodeDisableOptEvent(AbstractCode* code,
SharedFunctionInfo* shared) = 0;
- virtual void CodeDeoptEvent(Code* code, Address pc, int fp_to_sp_delta) = 0;
+ enum DeoptKind { kSoft, kLazy, kEager };
+ virtual void CodeDeoptEvent(DeoptKind kind, Code* code, Address pc,
Leszek Swirski 2017/03/21 14:28:39 nit: it would be neater if the Code was the first
+ int fp_to_sp_delta) = 0;
};
class CodeEventDispatcher {
@@ -170,8 +172,9 @@ class CodeEventDispatcher {
void CodeDisableOptEvent(AbstractCode* code, SharedFunctionInfo* shared) {
CODE_EVENT_DISPATCH(CodeDisableOptEvent(code, shared));
}
- void CodeDeoptEvent(Code* code, Address pc, int fp_to_sp_delta) {
- CODE_EVENT_DISPATCH(CodeDeoptEvent(code, pc, fp_to_sp_delta));
+ void CodeDeoptEvent(CodeEventListener::DeoptKind kind, Code* code, Address pc,
+ int fp_to_sp_delta) {
+ CODE_EVENT_DISPATCH(CodeDeoptEvent(kind, code, pc, fp_to_sp_delta));
}
#undef CODE_EVENT_DISPATCH
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | src/deoptimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698