Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2753523002: VM: [KERNEL] handle single-argument string interpolation in VM (Closed)

Created:
3 years, 9 months ago by Dmitry Olshansky
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [KERNEL] handle single-argument string interpolation in VM Also ignore zero-width string pieces when creating StringConcatenation objects. Mostly fixes the regressions on CssLib.prettyPrint. R=ahe@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/12bbefdbed845e81005f531c10b47684de5edb5f

Patch Set 1 #

Total comments: 2

Patch Set 2 : VM: [KERNEL] handle single-argument string interpolation in VM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 1 chunk +11 lines, -3 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 2 chunks +35 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Olshansky
3 years, 9 months ago (2017-03-14 14:38:35 UTC) #2
ahe
Fasta changes: LGTM https://codereview.chromium.org/2753523002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2753523002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode821 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:821: // Contains more then just \' ...
3 years, 9 months ago (2017-03-14 14:58:44 UTC) #3
Dmitry Olshansky
Fixed spelling
3 years, 9 months ago (2017-03-14 15:19:40 UTC) #4
Vyacheslav Egorov (Google)
lgtm
3 years, 9 months ago (2017-03-15 15:11:58 UTC) #5
Dmitry Olshansky
3 years, 9 months ago (2017-03-16 12:33:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
12bbefdbed845e81005f531c10b47684de5edb5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698