Add status_summary and current_summary to tools/gardening

Add status_summary and current_summary to tools/gardening

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/fa8a35f439db733173ad8c302a055c011f7f1f23

[Johnni Winther, 2017-03-15 08:36:34]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-15 14:06:25]

LGTM

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/cur...
File tools/gardening/lib/current_summary.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/cur...
tools/gardening/lib/current_summary.dart:45: if (testName.contains(arg) ||
arg.contains(testName)) {
How about
  if (args.any((String selector) => testName.startsWith(selector))) {
     ...
  }
?

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
File tools/gardening/lib/status_summary.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
tools/gardening/lib/status_summary.dart:47: if (testName.contains(arg) ||
arg.contains(testName)) {
Use startsWith like above?

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
tools/gardening/lib/status_summary.dart:98: /// The preceding config line, i.e.
`[...]` line that contained this entry.
Add that it can be null (if it did not encounter a config line).

[Johnni Winther, 2017-03-15 14:32:17]

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/cur...
File tools/gardening/lib/current_summary.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/cur...
tools/gardening/lib/current_summary.dart:45: if (testName.contains(arg) ||
arg.contains(testName)) {
On 2017/03/15 14:06:25, karlklose wrote:
> How about
>   if (args.any((String selector) => testName.startsWith(selector))) {
>      ...
>   }
> ?

That wouldn't support test names that _don't_ include the test suite (finding
for arithmetic_test in 'Done language/arithmetic_test: pass').

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
File tools/gardening/lib/status_summary.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
tools/gardening/lib/status_summary.dart:47: if (testName.contains(arg) ||
arg.contains(testName)) {
On 2017/03/15 14:06:25, karlklose wrote:
> Use startsWith like above?

That wouldn't support test names that include the test suite (searching for
language/arithmetic_test in the language.status file).

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/sta...
tools/gardening/lib/status_summary.dart:98: /// The preceding config line, i.e.
`[...]` line that contained this entry.
On 2017/03/15 14:06:25, karlklose wrote:
> Add that it can be null (if it did not encounter a config line). 

It's will empty in that case. Added.

[Johnni Winther, 2017-03-15 14:33:20]

Description was changed from

==========
Add status_summary and current_summary to tools/gardening
==========

to

==========
Add status_summary and current_summary to tools/gardening

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fa8a35f439db733173ad8c302a055c011f7f1f23
==========

[Johnni Winther, 2017-03-15 14:33:22]

Committed patchset #2 (id:20001) manually as
fa8a35f439db733173ad8c302a055c011f7f1f23 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-03-15 22:35:12]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-15 22:35:13]

dbc

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
File tools/gardening/lib/src/buildbot_data.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/buildbot_data.dart:19: 'dart2js chrome tests',
FWIW, in my script (https://github.com/sigmundch/bot_failures) I used the json
API to discover the steps from the bots directly. It might be handy to use that
to prevent the list of steps from getting out of sync with the bots' recipes.

[Johnni Winther, 2017-03-16 08:43:35]

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
File tools/gardening/lib/src/buildbot_data.dart (right):

https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/buildbot_data.dart:19: 'dart2js chrome tests',
On 2017/03/15 22:35:13, Siggi Cherem (dart-lang) wrote:
> FWIW, in my script (https://github.com/sigmundch/bot_failures) I used the json
> API to discover the steps from the bots directly. It might be handy to use
that
> to prevent the list of steps from getting out of sync with the bots' recipes.

Tried your script - didn't run. Wrote my own last gardening, but the json api
has been discontinued in the meantime :( This was the (tedious) alternative.

[Siggi Cherem (dart-lang), 2017-03-17 23:52:17]

On 2017/03/16 08:43:35, Johnni Winther wrote:
>
https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
> File tools/gardening/lib/src/buildbot_data.dart (right):
> 
>
https://codereview.chromium.org/2753513005/diff/20001/tools/gardening/lib/src...
> tools/gardening/lib/src/buildbot_data.dart:19: 'dart2js chrome tests',
> On 2017/03/15 22:35:13, Siggi Cherem (dart-lang) wrote:
> > FWIW, in my script (https://github.com/sigmundch/bot_failures) I used the
json
> > API to discover the steps from the bots directly. It might be handy to use
> that
> > to prevent the list of steps from getting out of sync with the bots'
recipes.
> 
> Tried your script - didn't run. Wrote my own last gardening, but the json api
> has been discontinued in the meantime :( This was the (tedious) alternative.

Oh no - maybe that's why it didn't run? ... so sad, it was working really nicely
a week ago