Reject unadvertised encodings

net/base/net_error_list.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file intentionally does not have header guards, it's included
 // inside a macro to generate enum values.
 
 // This file contains the list of network errors.
 
 //
@@ skipping 684 matching lines @@
 NET_ERROR(INVALID_HTTP_RESPONSE, -370)
 
 // Initializing content decoding failed.
 NET_ERROR(CONTENT_DECODING_INIT_FAILED, -371)
 
 // Received HTTP/2 RST_STREAM frame with NO_ERROR error code.  This error should
 // be handled internally by HTTP/2 code, and should not make it above the
 // SpdyStream layer.
 NET_ERROR(SPDY_RST_STREAM_NO_ERROR_RECEIVED, -372)
 
+// Content decoding of the response body failed.
+NET_ERROR(INVALID_CONTENT_ENCODING, -373)

[Randy Smith (Not in Mondays), 2017/03/15 16:35:31]

I"m inclined instead to make this CONTENT_DECODING_FAILURE and update the
Net.ContentDecodingFailed2.FilterType histogram to include "unknown" (may need
to be at a different site than the current one).

[eustas, 2017/03/16 12:08:16]

Done. Yup, net/http -> net/filter dependency doesn't look natural...

[Randy Smith (Not in Mondays), 2017/03/16 17:50:43]

I've gone back and forth on whether to ask you to do this or not, but: Ryan S &
I have basically agreed that a net/http -> net/filter dependency is a fine one,
and I'd rather have the histogram recordings just come from a single place, so:
Could you create a static function for recording decoding failures on
FilterSourceStream and call it from that function and from here to unify the
locations that this histogram is recorded from?  I do think the dependency is ok
(good, even), and I'd rather have it clear in code terms that there are multiple
places that are adding to this histogram.

Sorry about the extra work :-J.

[eustas, 2017/03/20 13:05:18]

No worries =)

+
 // The cache does not have the requested entry.
 NET_ERROR(CACHE_MISS, -400)
 
 // Unable to read from the disk cache.
 NET_ERROR(CACHE_READ_FAILURE, -401)
 
 // Unable to write to the disk cache.
 NET_ERROR(CACHE_WRITE_FAILURE, -402)
 
 // The operation is not supported for this entry.
@@ skipping 140 matching lines @@
 NET_ERROR(DNS_TIMED_OUT, -803)
 
 // The entry was not found in cache, for cache-only lookups.
 NET_ERROR(DNS_CACHE_MISS, -804)
 
 // Suffix search list rules prevent resolution of the given host name.
 NET_ERROR(DNS_SEARCH_EMPTY, -805)
 
 // Failed to sort addresses according to RFC3484.
 NET_ERROR(DNS_SORT_ERROR, -806)