tools/metrics/histograms/histograms.xml - Issue 2753453003: Reject unadvertised encodings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2753453003: Reject unadvertised encodings (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ac4e64011ed63046411ed39fe56f03bcdb570fbc..0a256ac64c0d35bd0730c96e32351d7a34ef4d0b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -103716,6 +103716,16 @@ from previous Chrome versions.

+ <int value="8" label="Rejected">

+ Unlike other values, this one is reported from HttpNetworkTransaction in

+ case when unadvertised, but known encoding appears in

+ "Content-Encoding".

Randy Smith (Not in Mondays) 2017/04/05 00:03:32 nit: Add "... and is thus not comparable with the

+ </int>

+ <int value="9" label="Unknown">

+ Reported from URLRequestHttpJob::SetUpSourceStream when unknown encoding

+ appears in "Content-Encoding" header. Despite of being reported in

+ this histogram, event does not cause CONTENT_DECODING_FAILED error.

+ </int>

</enum>

« no previous file with comments | « net/url_request/url_request_http_job_unittest.cc ('k') | no next file » | no next file with comments »