Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2753443007: Roll closure compiler (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll closure compiler Change log: https://github.com/google/closure-compiler/compare/72c88ff7e9e85b4c2413274539897b6d43024d48...b2f2d2f3309c7ee61816e068050651af27bccdfa chrome_extensions.js: 9f5d27bb1a9ad197c67f9eab61ea511d99aa4e8c -> a3f41820d1260b0d7ed13acac526b803ac6c1870 TBR=fukino@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : roll compiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -92 lines) Patch
M third_party/closure_compiler/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/compiler/compiler.jar View Binary file 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 10 chunks +145 lines, -78 lines 0 comments Download
M third_party/closure_compiler/externs/web_animations.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/closure_compiler/roll_closure_compiler View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/externs/webview_tag.js View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
TBR=fukino@ for ui/file_manager (feel free to look at rest of changes as well)
3 years, 9 months ago (2017-03-16 04:20:08 UTC) #4
Dan Beam
landed as https://crrev.com/ea14bb07970c70c562d49496e90e02cd607b0ad7 but didn't close the issue for some reason...
3 years, 9 months ago (2017-03-16 04:27:37 UTC) #5
fukino
3 years, 9 months ago (2017-03-16 06:31:06 UTC) #6
Message was sent while issue was closed. 
LGTM.
I saw the same issue (issue not closed after land) recently...

Powered by Google App Engine
This is Rietveld 408576698