MD Settings: Pointers: Avoid setting mouse swap pref while mouse pressed

chrome/browser/resources/settings/device_page/pointers.js

Index: chrome/browser/resources/settings/device_page/pointers.js
diff --git a/chrome/browser/resources/settings/device_page/pointers.js b/chrome/browser/resources/settings/device_page/pointers.js
index dda8bf02cc67229a128dc0edfe0e4890b2e6de42..6655b7b829d38703130dbe3dae80fffee936c410 100644
--- a/chrome/browser/resources/settings/device_page/pointers.js
+++ b/chrome/browser/resources/settings/device_page/pointers.js
@@ -32,6 +32,11 @@ Polymer({
     },
   },
 
+  // Used to correctly identify when the mouse swap toggle has changed and
+  // the mouse button has been released. crbug.com/686949.
+  receivedMouseSwapButtonsUp_: false,
+  receivedMouseSwapButtonsChange_: false,
+
   /**
    * Prevents the link from activating its parent paper-radio-button.
    * @param {!Event} e
@@ -46,8 +51,36 @@ Polymer({
    * @param {boolean} hasMouse
    * @param {boolean} hasTouchpad
    * @return {string}
+   * @private
    */
   getSubsectionClass_: function(hasMouse, hasTouchpad) {
     return hasMouse && hasTouchpad ? 'subsection' : '';
   },
+
+  /** @private */
+  onMouseSwapButtonsDown_: function() {
+    this.receivedMouseSwapButtonsUp_ = false;

[michaelpg, 2017/03/17 22:53:26]

Tracking two booleans is confusing, and the "why" isn't really clear.

Would only tracking mouseDown achieve the same thing? (This simplifies the
process a bit by not tracking whether the state has "changed" -- setting the
pref value to its current value should have no effect.)

onDown_() {
  this.mouseDown_ = true;
},

onUp_() {
  this.mouseDown_ = false;
  this.$.mouseSwapButton.sendPrefChange();
},

onChange_() {
  if (!this.mouseDown_)
    this.$.mouseSwapButton.sendPrefChange();
},

[michaelpg, 2017/03/17 23:09:14]

So as you said offline, keeping both booleans avoids the redundant
sendPrefChange call. If we keep them, could we rename them, e.g.
isMouseDownOnSwapToggle_ and hasSentSwapTogglePrefChange_ -- tracking the state
of things, rather than tracking which raw events we've received?

+    this.receivedMouseSwapButtonsChange_ = false;
+  },
+
+  /** @private */
+  onMouseSwapButtonsUp_: function() {
+    this.receivedMouseSwapButtonsUp_ = true;
+    this.maybeSendMouseSwapButtonsPrefChange_();
+  },
+
+  /** @private */
+  onMouseSwapButtonsChange_: function(event) {
+    this.receivedMouseSwapButtonsChange_ = true;
+    this.maybeSendMouseSwapButtonsPrefChange_();
+  },
+
+  /** @private */
+  maybeSendMouseSwapButtonsPrefChange_: function() {
+    if (this.receivedMouseSwapButtonsUp_ &&
+        this.receivedMouseSwapButtonsChange_) {
+      /** @type {!SettingsToggleButtonElement} */ (this.$.mouseSwapButton)
+          .sendPrefChange();
+    }
+  },
 });