Pass response headers to the PDF plugin

Pass response headers to the PDF plugin

The streamsPrivate API provides the response headers for the original URL request in the stream details. This passes them along to the plugin with the URL.

This also adds the ability for the plugin to cancel the stream, which is necessary if the plugin wants to re-request the original URL.

BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272710

[Lei Zhang, 2014-05-22 00:13:20]

lgtm with 1 question

https://codereview.chromium.org/275333004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/275333004/diff/40001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf.js:95: headers += header + ': ' +
Are we likely to run into any parsing problems with header entries that may
contain ': ' ?

[raymes, 2014-05-22 00:28:48]

The CQ bit was checked by raymes@chromium.org

[raymes, 2014-05-22 00:29:02]

I don't think so because this just reconstructs the parsed headers.
It's not ideal but I don't think it should cause any bugs.

On Thu, May 22, 2014 at 10:13 AM,  <thestig@chromium.org> wrote:
> lgtm with 1 question
>
>
>
https://codereview.chromium.org/275333004/diff/40001/chrome/browser/resources...
> File chrome/browser/resources/pdf/pdf.js (right):
>
>
https://codereview.chromium.org/275333004/diff/40001/chrome/browser/resources...
> chrome/browser/resources/pdf/pdf.js:95: headers += header + ': ' +
> Are we likely to run into any parsing problems with header entries that
> may contain ': ' ?
>
> https://codereview.chromium.org/275333004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-05-22 00:30:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/275333004/40001

[commit-bot: I haz the power, 2014-05-22 07:49:26]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-05-22 10:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 10:02:11]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Lei Zhang, 2014-05-24 06:41:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-24 06:41:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/275333004/40001

[commit-bot: I haz the power, 2014-05-24 12:18:30]

Change committed as 272710