[dart:io] Move Platform.ansiSupported to {Stdin,Stdout}.supportsAnsiEscapes

runtime/bin/stdio.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/stdio.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 51 matching lines @@
 void FUNCTION_NAME(Stdin_SetLineMode)(Dart_NativeArguments args) {
   bool enabled = DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 0));
   if (Stdin::SetLineMode(enabled)) {
     Dart_SetReturnValue(args, Dart_True());
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
 }
 
 
+void FUNCTION_NAME(Stdin_AnsiSupported)(Dart_NativeArguments args) {
+  bool supported = false;
+  if (Stdin::AnsiSupported(&supported)) {
+    Dart_SetBooleanReturnValue(args, supported);
+  } else {
+    Dart_SetReturnValue(args, DartUtils::NewDartOSError());
+  }
+}
+
+
 void FUNCTION_NAME(Stdout_GetTerminalSize)(Dart_NativeArguments args) {
   if (!Dart_IsInteger(Dart_GetNativeArgument(args, 0))) {
     OSError os_error(-1, "Invalid argument", OSError::kUnknown);
     Dart_SetReturnValue(args, DartUtils::NewDartOSError(&os_error));
     return;
   }
   intptr_t fd = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
   if ((fd != 1) && (fd != 2)) {
     Dart_SetReturnValue(args, Dart_NewApiError("Terminal fd must be 1 or 2"));
     return;
   }
 
   int size[2];
   if (Stdout::GetTerminalSize(fd, size)) {
     Dart_Handle list = Dart_NewList(2);
     Dart_ListSetAt(list, 0, Dart_NewInteger(size[0]));
     Dart_ListSetAt(list, 1, Dart_NewInteger(size[1]));
     Dart_SetReturnValue(args, list);
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
 }
 
+
+void FUNCTION_NAME(Stdout_AnsiSupported)(Dart_NativeArguments args) {
+  if (!Dart_IsInteger(Dart_GetNativeArgument(args, 0))) {
+    OSError os_error(-1, "Invalid argument", OSError::kUnknown);
+    Dart_SetReturnValue(args, DartUtils::NewDartOSError(&os_error));
+    return;
+  }
+  intptr_t fd = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
+  if ((fd != 1) && (fd != 2)) {
+    Dart_SetReturnValue(args, Dart_NewApiError("Terminal fd must be 1 or 2"));
+    return;
+  }

[siva, 2017/03/17 23:54:24]

The above chunk could be written as (avoids multiple transitions into the VM)
intptr_fd = -1;
Dart_Handle result = Dart_GetNativeIntegerArgument(args, 0, &fd);
if (Dart_IsError(result) || (fd != 1) || (fd != 2)) {
  Dart_SetReturnValue(args, Dart_IsError(result) ? result :
Dart_NewApiError("Terminal fd must be 1 or 2"));
}
....
....

+  bool supported = false;
+  if (Stdout::AnsiSupported(fd, &supported)) {
+    Dart_SetBooleanReturnValue(args, supported);
+  } else {
+    Dart_SetReturnValue(args, DartUtils::NewDartOSError());
+  }
+}
+
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)