Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2753223003: Really disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/cancelable_callback.h" 10 #include "base/cancelable_callback.h"
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 // we try to close the inspected page. 762 // we try to close the inspected page.
763 // Flaky on Windows. http://crbug.com/702171 763 // Flaky on Windows. http://crbug.com/702171
764 #if defined(OS_WIN) 764 #if defined(OS_WIN)
765 #define MAYBE_TestUndockedDevToolsInspectedTabClose \ 765 #define MAYBE_TestUndockedDevToolsInspectedTabClose \
766 DISABLED_TestUndockedDevToolsInspectedTabClose 766 DISABLED_TestUndockedDevToolsInspectedTabClose
767 #else 767 #else
768 #define MAYBE_TestUndockedDevToolsInspectedTabClose \ 768 #define MAYBE_TestUndockedDevToolsInspectedTabClose \
769 TestUndockedDevToolsInspectedTabClose 769 TestUndockedDevToolsInspectedTabClose
770 #endif 770 #endif
771 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 771 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
772 TestUndockedDevToolsInspectedTabClose) { 772 MAYBE_TestUndockedDevToolsInspectedTabClose) {
773 RunBeforeUnloadSanityTest(false, base::Bind( 773 RunBeforeUnloadSanityTest(false, base::Bind(
774 &DevToolsBeforeUnloadTest::CloseInspectedTab, 774 &DevToolsBeforeUnloadTest::CloseInspectedTab,
775 base::Unretained(this))); 775 base::Unretained(this)));
776 } 776 }
777 777
778 // Tests that BeforeUnload event gets called on undocked devtools if 778 // Tests that BeforeUnload event gets called on undocked devtools if
779 // we try to close the inspected browser. 779 // we try to close the inspected browser.
780 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171 780 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
781 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS) 781 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
782 #define MAYBE_TestUndockedDevToolsInspectedBrowserClose \ 782 #define MAYBE_TestUndockedDevToolsInspectedBrowserClose \
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 RunTestFunction(window, "testWindowInitializedOnNavigateBack"); 1588 RunTestFunction(window, "testWindowInitializedOnNavigateBack");
1589 1589
1590 DevToolsWindowTesting::CloseDevToolsWindowSync(window); 1590 DevToolsWindowTesting::CloseDevToolsWindowSync(window);
1591 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory); 1591 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory);
1592 } 1592 }
1593 1593
1594 // Tests scripts panel showing. 1594 // Tests scripts panel showing.
1595 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) { 1595 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) {
1596 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL); 1596 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL);
1597 } 1597 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698