third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2753193002: Editing: Indent command: Do not insert BLOCKQUOTE under the root HTML element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2753193002: Editing: Indent command: Do not insert BLOCKQUOTE under the root HTML element. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('K') | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index fb353fdb7b7853b4c85314c897247b4e190f174c..c94e20a314fa721bc82c91de70caf1b10b43e9a0 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -61,6 +61,9 @@ void ApplyBlockElementCommand::doApply(EditingState* editingState) {

// execution, which updates layout before entering doApply().

DCHECK(!document().needsLayoutTreeUpdate());

+ // We don't want to modify outside of <body>.

+ shrinkEndingSelectionToFitBody();

VisiblePosition visibleEnd = endingSelection().visibleEnd();

VisiblePosition visibleStart = endingSelection().visibleStart();

if (visibleStart.isNull() || visibleStart.isOrphan() || visibleEnd.isNull() ||