Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: ash/common/metrics/pointer_metrics_recorder_unittest.cc

Issue 2753163004: Remove ID from ui::PointerEvent's constructors (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | services/ui/ws/drag_controller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/metrics/pointer_metrics_recorder.h" 5 #include "ash/common/metrics/pointer_metrics_recorder.h"
6 6
7 #include "ash/common/wm/maximize_mode/maximize_mode_controller.h" 7 #include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
8 #include "ash/common/wm_shell.h" 8 #include "ash/common/wm_shell.h"
9 #include "ash/common/wm_window.h" 9 #include "ash/common/wm_window.h"
10 #include "ash/public/cpp/shell_window_ids.h" 10 #include "ash/public/cpp/shell_window_ids.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 61 }
62 62
63 } // namespace 63 } // namespace
64 64
65 // Verifies that histogram is not recorded when receiving events that are not 65 // Verifies that histogram is not recorded when receiving events that are not
66 // down events. 66 // down events.
67 TEST_F(PointerMetricsRecorderTest, NonDownEventsInAllPointerHistogram) { 67 TEST_F(PointerMetricsRecorderTest, NonDownEventsInAllPointerHistogram) {
68 std::unique_ptr<views::Widget> target = 68 std::unique_ptr<views::Widget> target =
69 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect()); 69 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect());
70 const ui::PointerEvent pointer_event( 70 const ui::PointerEvent pointer_event(
71 ui::ET_POINTER_UP, gfx::Point(), gfx::Point(), 0, 0, 0, 71 ui::ET_POINTER_UP, gfx::Point(), gfx::Point(), 0, 0,
72 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 72 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE, 0),
73 base::TimeTicks()); 73 base::TimeTicks());
74 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 74 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
75 target.get()); 75 target.get());
76 76
77 histogram_tester_->ExpectTotalCount(kFormFactorHistogramName, 0); 77 histogram_tester_->ExpectTotalCount(kFormFactorHistogramName, 0);
78 histogram_tester_->ExpectTotalCount(kInputHistogramName, 0); 78 histogram_tester_->ExpectTotalCount(kInputHistogramName, 0);
79 histogram_tester_->ExpectTotalCount(kDestinationHistogramName, 0); 79 histogram_tester_->ExpectTotalCount(kDestinationHistogramName, 0);
80 } 80 }
81 81
82 // Verifies that down events from different inputs are recorded. 82 // Verifies that down events from different inputs are recorded.
83 TEST_F(PointerMetricsRecorderTest, DownEventPerInput) { 83 TEST_F(PointerMetricsRecorderTest, DownEventPerInput) {
84 std::unique_ptr<views::Widget> target = 84 std::unique_ptr<views::Widget> target =
85 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect()); 85 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect());
86 86
87 const ui::PointerEvent unknown_event( 87 const ui::PointerEvent unknown_event(
88 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 88 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
89 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_UNKNOWN), 89 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_UNKNOWN, 0),
90 base::TimeTicks()); 90 base::TimeTicks());
91 pointer_metrics_recorder_->OnPointerEventObserved(unknown_event, gfx::Point(), 91 pointer_metrics_recorder_->OnPointerEventObserved(unknown_event, gfx::Point(),
92 target.get()); 92 target.get());
93 histogram_tester_->ExpectBucketCount(kInputHistogramName, 0, 1); 93 histogram_tester_->ExpectBucketCount(kInputHistogramName, 0, 1);
94 94
95 const ui::PointerEvent mouse_event( 95 const ui::PointerEvent mouse_event(
96 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 96 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
97 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 97 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE, 0),
98 base::TimeTicks()); 98 base::TimeTicks());
99 pointer_metrics_recorder_->OnPointerEventObserved(mouse_event, gfx::Point(), 99 pointer_metrics_recorder_->OnPointerEventObserved(mouse_event, gfx::Point(),
100 target.get()); 100 target.get());
101 histogram_tester_->ExpectBucketCount(kInputHistogramName, 1, 1); 101 histogram_tester_->ExpectBucketCount(kInputHistogramName, 1, 1);
102 102
103 const ui::PointerEvent stylus_event( 103 const ui::PointerEvent stylus_event(
104 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 104 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
105 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_PEN), 105 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_PEN, 0),
106 base::TimeTicks()); 106 base::TimeTicks());
107 pointer_metrics_recorder_->OnPointerEventObserved(stylus_event, gfx::Point(), 107 pointer_metrics_recorder_->OnPointerEventObserved(stylus_event, gfx::Point(),
108 target.get()); 108 target.get());
109 histogram_tester_->ExpectBucketCount(kInputHistogramName, 2, 1); 109 histogram_tester_->ExpectBucketCount(kInputHistogramName, 2, 1);
110 110
111 const ui::PointerEvent stylus_event2( 111 const ui::PointerEvent stylus_event2(
112 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 112 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
113 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_ERASER), 113 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_ERASER, 0),
114 base::TimeTicks()); 114 base::TimeTicks());
115 pointer_metrics_recorder_->OnPointerEventObserved(stylus_event2, gfx::Point(), 115 pointer_metrics_recorder_->OnPointerEventObserved(stylus_event2, gfx::Point(),
116 target.get()); 116 target.get());
117 histogram_tester_->ExpectBucketCount(kInputHistogramName, 2, 2); 117 histogram_tester_->ExpectBucketCount(kInputHistogramName, 2, 2);
118 118
119 const ui::PointerEvent touch_event( 119 const ui::PointerEvent touch_event(
120 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 120 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
121 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH), 121 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH, 0),
122 base::TimeTicks()); 122 base::TimeTicks());
123 pointer_metrics_recorder_->OnPointerEventObserved(touch_event, gfx::Point(), 123 pointer_metrics_recorder_->OnPointerEventObserved(touch_event, gfx::Point(),
124 target.get()); 124 target.get());
125 histogram_tester_->ExpectBucketCount(kInputHistogramName, 3, 1); 125 histogram_tester_->ExpectBucketCount(kInputHistogramName, 3, 1);
126 } 126 }
127 127
128 // Verifies that down events in different form factors are recorded. 128 // Verifies that down events in different form factors are recorded.
129 TEST_F(PointerMetricsRecorderTest, DownEventPerFormFactor) { 129 TEST_F(PointerMetricsRecorderTest, DownEventPerFormFactor) {
130 std::unique_ptr<views::Widget> target = 130 std::unique_ptr<views::Widget> target =
131 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect()); 131 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect());
132 const ui::PointerEvent pointer_event( 132 const ui::PointerEvent pointer_event(
133 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 133 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
134 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 134 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
135 base::TimeTicks()); 135 base::TimeTicks());
136 136
137 // Enable maximize mode 137 // Enable maximize mode
138 WmShell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager( 138 WmShell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager(
139 true); 139 true);
140 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 140 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
141 target.get()); 141 target.get());
142 histogram_tester_->ExpectBucketCount(kFormFactorHistogramName, 1, 1); 142 histogram_tester_->ExpectBucketCount(kFormFactorHistogramName, 1, 1);
143 143
144 // Disable maximize mode 144 // Disable maximize mode
145 WmShell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager( 145 WmShell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager(
146 false); 146 false);
147 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 147 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
148 target.get()); 148 target.get());
149 histogram_tester_->ExpectBucketCount(kFormFactorHistogramName, 0, 1); 149 histogram_tester_->ExpectBucketCount(kFormFactorHistogramName, 0, 1);
150 } 150 }
151 151
152 // Verifies that down events dispatched to different destinations are recorded. 152 // Verifies that down events dispatched to different destinations are recorded.
153 TEST_F(PointerMetricsRecorderTest, DownEventPerDestination) { 153 TEST_F(PointerMetricsRecorderTest, DownEventPerDestination) {
154 std::unique_ptr<views::Widget> target = 154 std::unique_ptr<views::Widget> target =
155 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect()); 155 CreateTestWidget(nullptr, kShellWindowId_DefaultContainer, gfx::Rect());
156 const ui::PointerEvent pointer_event( 156 const ui::PointerEvent pointer_event(
157 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0, 0, 157 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), 0, 0,
158 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 158 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE, 0),
159 base::TimeTicks()); 159 base::TimeTicks());
160 160
161 WmWindow* window = WmWindow::Get(target->GetNativeWindow()); 161 WmWindow* window = WmWindow::Get(target->GetNativeWindow());
162 CHECK(window); 162 CHECK(window);
163 163
164 window->SetAppType(static_cast<int>(AppType::OTHERS)); 164 window->SetAppType(static_cast<int>(AppType::OTHERS));
165 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 165 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
166 target.get()); 166 target.get());
167 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 0, 1); 167 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 0, 1);
168 168
169 window->SetAppType(static_cast<int>(AppType::BROWSER)); 169 window->SetAppType(static_cast<int>(AppType::BROWSER));
170 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 170 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
171 target.get()); 171 target.get());
172 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 1, 1); 172 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 1, 1);
173 173
174 window->SetAppType(static_cast<int>(AppType::CHROME_APP)); 174 window->SetAppType(static_cast<int>(AppType::CHROME_APP));
175 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 175 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
176 target.get()); 176 target.get());
177 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 2, 1); 177 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 2, 1);
178 178
179 window->SetAppType(static_cast<int>(AppType::ARC_APP)); 179 window->SetAppType(static_cast<int>(AppType::ARC_APP));
180 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(), 180 pointer_metrics_recorder_->OnPointerEventObserved(pointer_event, gfx::Point(),
181 target.get()); 181 target.get());
182 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 3, 1); 182 histogram_tester_->ExpectBucketCount(kDestinationHistogramName, 3, 1);
183 } 183 }
184 184
185 } // namespace ash 185 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | services/ui/ws/drag_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698