Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/process/process_info_linux.cc

Issue 2753133002: Add process uptime metadata event in tracing (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/trace_log.cc » ('j') | base/trace_event/trace_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process_info_linux.cc
diff --git a/base/process/process_info_linux.cc b/base/process/process_info_linux.cc
index 7cec8f4e4ecbd982b02a98f8ae5804b96ebfb204..2f227484f5f1cff9c9fe0a84258c87ffa17c9426 100644
--- a/base/process/process_info_linux.cc
+++ b/base/process/process_info_linux.cc
@@ -17,10 +17,12 @@ namespace base {
const Time CurrentProcessInfo::CreationTime() {
int64_t start_ticks =
internal::ReadProcSelfStatsAndGetFieldAsInt64(internal::VM_STARTTIME);
- DCHECK(start_ticks);
+ if (!start_ticks)
Nico 2017/03/21 21:01:55 this is covered by tests, yes?
ssid 2017/03/22 00:41:08 I added an unittest.
+ return Time();
TimeDelta start_offset = internal::ClockTicksToTimeDelta(start_ticks);
Time boot_time = internal::GetBootTime();
- DCHECK(!boot_time.is_null());
+ if (boot_time.is_null())
+ return Time();
return Time(boot_time + start_offset);
}
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/trace_log.cc » ('j') | base/trace_event/trace_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698