Support terminal colors on Windows 10.

Support terminal colors on Windows 10.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/b018d8cfae43d3b4e17d276b1fbc1bd7f17b4e6c

[ahe, 2017-03-16 10:14:15]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-16 10:15:03]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, kustermann@google.com, sortie@google.com

[Johnni Winther, 2017-03-16 10:27:19]

lgtm

[ahe, 2017-03-16 10:31:19]

Description was changed from

==========
Support terminal colors on Windows 10.
==========

to

==========
Support terminal colors on Windows 10.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b018d8cfae43d3b4e17d276b1fbc1bd7f17b4e6c
==========

[ahe, 2017-03-16 10:31:20]

Committed patchset #1 (id:20001) manually as
b018d8cfae43d3b4e17d276b1fbc1bd7f17b4e6c (presubmit successful).

[sortie, 2017-03-16 10:32:03]

lgtm

https://codereview.chromium.org/2753033002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/colors.dart (right):

https://codereview.chromium.org/2753033002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:130: // `Platform.ansiSupported` is
hard-coded to true on non-Windows platforms.
This comment may get out of date in the future. You may want to specify when
"currently" is. If Platform.ansiSupported gains support for Unix in the future
(for instance if the vm links in terminfo so there's no need to invoke tput),
the below code should possibly be wholly or partially removed. If this is the
plan, possibly the comment should be of the format "The below code can be
removed when $condition happens."

[ahe, 2017-03-16 11:06:30]

Thank you!

https://codereview.chromium.org/2753033002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/colors.dart (right):

https://codereview.chromium.org/2753033002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/colors.dart:130: // `Platform.ansiSupported` is
hard-coded to true on non-Windows platforms.
On 2017/03/16 10:32:03, sortie wrote:
> This comment may get out of date in the future. You may want to specify when
> "currently" is. If Platform.ansiSupported gains support for Unix in the future
> (for instance if the vm links in terminfo so there's no need to invoke tput),
> the below code should possibly be wholly or partially removed. If this is the
> plan, possibly the comment should be of the format "The below code can be
> removed when $condition happens."

I normally expect that people look in the revision history when they see
comments like this. In the past, I've found that I'm really bad at predicting
exactly what future condition must be satisfied before code can be removed.