Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

Move paint-order, stroke-width, stroke-linejoin, and stroke-linecap styles out of SVG

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[Shanmuga Pandi, 2017-03-16 09:55:14]

Description was changed from

==========
Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

This patch moves these styles out of svg and sets the properties on video cues.

BUG=692841
==========

to

==========
Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

This patch moves these styles out of svg and sets the properties on video cues.

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Shanmuga Pandi, 2017-03-16 09:56:32]

Description was changed from

==========
Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

This patch moves these styles out of svg and sets the properties on video cues.

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Shanmuga Pandi, 2017-03-16 14:29:59]

shanmuga.m@samsung.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[Shanmuga Pandi, 2017-03-16 14:30:00]

PTAL !!

[fs, 2017-03-16 15:49:26]

On 2017/03/16 at 14:30:00, shanmuga.m wrote:
> PTAL !!

I think this is missing the part where these properties are actually applied to
HTML text? Will that be a follow-up? Also, we need to consider how this
interacts with -webkit-text-stroke* (IIRC) We could land the tests in some form
I suppose, because those should be independent of the change in general.

[Shanmuga Pandi, 2017-03-17 04:59:02]

On 2017/03/16 15:49:26, fs wrote:
> On 2017/03/16 at 14:30:00, shanmuga.m wrote:
> > PTAL !!
> 
> I think this is missing the part where these properties are actually applied
to
> HTML text? Will that be a follow-up? Also, we need to consider how this
> interacts with -webkit-text-stroke* (IIRC) We could land the tests in some
form
> I suppose, because those should be independent of the change in general.

Hmm.. There is one change missing in this patch from original webkit patch.
http://trac.webkit.org/changeset/212562/trunk/Source/WebCore/page/CaptionUser...

Apart from this change, I am not seeing any part interacts with
-webkit-text-stroke* or applied to HTML text.
Am I missing some thing ?

Also I could not find like CaptionUserPreferencesMediaAF.cpp in blink yet :(

[Shanmuga Pandi, 2017-03-17 09:10:56]

Also as per webkit bug 
https://bugs.webkit.org/show_bug.cgi?id=168044#c36

Follow up patch for TextPainter will be submitted.


So this patch has only CSS bit part :)

[fs, 2017-03-17 09:14:46]

On 2017/03/17 at 04:59:02, shanmuga.m wrote:
> On 2017/03/16 15:49:26, fs wrote:
> > On 2017/03/16 at 14:30:00, shanmuga.m wrote:
> > > PTAL !!
> > 
> > I think this is missing the part where these properties are actually applied
to
> > HTML text? Will that be a follow-up? Also, we need to consider how this
> > interacts with -webkit-text-stroke* (IIRC) We could land the tests in some
form
> > I suppose, because those should be independent of the change in general.
> 
> Hmm.. There is one change missing in this patch from original webkit patch.
>
http://trac.webkit.org/changeset/212562/trunk/Source/WebCore/page/CaptionUser...
> 
> Apart from this change, I am not seeing any part interacts with
-webkit-text-stroke* or applied to HTML text.
> Am I missing some thing ?

You're probably not missing anything, but the commit you reference seems to be
missing the same things (and earlier patch in the bug seemed to have had
something to that effect, but the one landed does not.)

> Also I could not find like CaptionUserPreferencesMediaAF.cpp in blink yet :(

No, Blink does not have that (we have some similar code for track
configuration), and I wouldn't expect that piece to be relevant.

[Shanmuga Pandi, 2017-03-17 09:20:01]

Description was changed from

==========
Apply SVG styles paint-order, stroke-linejoin, and stroke-linecap on DOM text

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move paint-order, stroke-linejoin, and stroke-linecap styles out of SVG

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Shanmuga Pandi, 2017-03-17 09:21:09]

Description was changed from

==========
Move paint-order, stroke-linejoin, and stroke-linecap styles out of SVG

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move paint-order, stroke-width, stroke-linejoin, and stroke-linecap styles out
of SVG

This patch moves these styles out of svg and sets the properties on video cues.

Base patch:
http://trac.webkit.org/changeset/212562

BUG=692841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Shanmuga Pandi, 2017-03-17 09:21:40]

Updated the description as per patch content.

[fs, 2017-03-17 09:38:16]

On 2017/03/17 at 09:10:56, shanmuga.m wrote:
> Also as per webkit bug 
> https://bugs.webkit.org/show_bug.cgi?id=168044#c36
> 
> Follow up patch for TextPainter will be submitted.
> 
> 
> So this patch has only CSS bit part :)

Let's wait until we have a useful complex of CLs. (The TextPainter changes does
not really need to depend on having the ComputedStyle bits moved out from
SVGComputedStyle.) I wonder if this also wouldn't warrant an I2S, because it
essentially implements part of https://drafts.fxtf.org/paint/. Also, since this
seems to be set up to work/interact with the -webkit-text-stroke-* properties
(speculating based on the WebKit patch), some consideration needs to taken for
that as well (for example how does 'stroke-width' interact with
'-webkit-text-stroke-width'?)

[Shanmuga Pandi, 2017-03-17 09:40:18]

On 2017/03/17 09:38:16, fs wrote:
> On 2017/03/17 at 09:10:56, shanmuga.m wrote:
> > Also as per webkit bug 
> > https://bugs.webkit.org/show_bug.cgi?id=168044#c36
> > 
> > Follow up patch for TextPainter will be submitted.
> > 
> > 
> > So this patch has only CSS bit part :)
> 
> Let's wait until we have a useful complex of CLs. (The TextPainter changes
does
> not really need to depend on having the ComputedStyle bits moved out from
> SVGComputedStyle.) I wonder if this also wouldn't warrant an I2S, because it
> essentially implements part of https://drafts.fxtf.org/paint/. Also, since
this
> seems to be set up to work/interact with the -webkit-text-stroke-* properties
> (speculating based on the WebKit patch), some consideration needs to taken for
> that as well (for example how does 'stroke-width' interact with
> '-webkit-text-stroke-width'?)

Agree, Lets wait.