Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

Issue 2753013003: Bindings: Remove DOMWrapperWorld::fromWorldId() for cleanup (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
diff --git a/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp b/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
index 3e285770791ffd526f62721ba751bd3af11b29ec..dbbf9acc733e76630b44d6686a8523860eebdd23 100644
--- a/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
+++ b/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
@@ -132,17 +132,14 @@ Vector<v8::Local<v8::Value>> V8FunctionExecutor::execute(LocalFrame* frame) {
SuspendableScriptExecutor* SuspendableScriptExecutor::create(
LocalFrame* frame,
- int worldID,
+ RefPtr<DOMWrapperWorld> world,
const HeapVector<ScriptSourceCode>& sources,
bool userGesture,
WebScriptExecutionCallback* callback) {
- // TODO(devlin): Passing in a v8::Isolate* directly would be better than
- // toIsolate() here.
- ScriptState* scriptState = ScriptState::forWorld(
- frame, *DOMWrapperWorld::fromWorldId(toIsolate(frame), worldID));
+ ScriptState* scriptState = ScriptState::forWorld(frame, *world);
return new SuspendableScriptExecutor(
frame, scriptState, callback,
- new WebScriptExecutor(sources, worldID, userGesture));
+ new WebScriptExecutor(sources, world->worldId(), userGesture));
}
void SuspendableScriptExecutor::createAndRun(
« no previous file with comments | « third_party/WebKit/Source/web/SuspendableScriptExecutor.h ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698