Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2752853002: Improve printing of generic function types and add tests (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve printing of generic function types and add tests R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/40ca7292fe39556de5c5c42c8d4a988e603c33cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 4 chunks +10 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 2 chunks +19 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-15 17:58:30 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-15 18:10:17 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-15 18:19:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40ca7292fe39556de5c5c42c8d4a988e603c33cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698