Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2752803003: Add test case to regress case where fields of a closure are accessed (reproduces the problem we enc… (Closed)

Created:
3 years, 9 months ago by siva
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test case to regress case where fields of a closure are accessed (reproduces the problem we encountered in b/36131545) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4bc53826f78744c4c3e91a8c6f70c042f4ddc654

Patch Set 1 #

Patch Set 2 : Address self review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 9 months ago (2017-03-15 18:02:19 UTC) #2
rmacnak
lgtm
3 years, 9 months ago (2017-03-15 19:48:35 UTC) #3
siva
3 years, 9 months ago (2017-03-15 20:41:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4bc53826f78744c4c3e91a8c6f70c042f4ddc654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698