Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4487)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

Issue 2752693003: chrome/android: Update toolbar drawing in native. (Closed)
Patch Set: .. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java
index fa95604aa482dc6446cbbd9ce2071be30b015c3d..8d61ca798f1afcadadf5dc5ea4a02921e11ad430 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java
@@ -17,6 +17,7 @@ import android.widget.FrameLayout;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.compositor.layouts.eventfilter.EdgeSwipeHandler;
+import org.chromium.chrome.browser.compositor.resources.ResourceFactory;
import org.chromium.chrome.browser.contextualsearch.SwipeRecognizer;
import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.ClipDrawableProgressBar.DrawingInfo;
@@ -160,6 +161,8 @@ public class ToolbarControlContainer extends FrameLayout implements ControlConta
private static class ToolbarViewResourceAdapter extends ViewResourceAdapter {
private final int[] mTempPosition = new int[2];
+ private final Rect mLocationBarRect = new Rect();
+ private final Rect mToolbarRect = new Rect();
private final View mToolbarContainer;
private Toolbar mToolbar;
@@ -220,16 +223,18 @@ public class ToolbarControlContainer extends FrameLayout implements ControlConta
}
@Override
- protected void computeContentPadding(Rect outContentPadding) {
- outContentPadding.set(
- 0, mTabStripHeightPx, mToolbarContainer.getWidth(), mToolbar.getHeight());
- }
-
- @Override
- protected void computeContentAperture(Rect outContentAperture) {
- mToolbar.getLocationBarContentRect(outContentAperture);
+ public long createNativeResource() {
mToolbar.getPositionRelativeToContainer(mToolbarContainer, mTempPosition);
- outContentAperture.offset(mTempPosition[0], mTempPosition[1]);
+ mToolbarRect.set(mTempPosition[0], mTempPosition[1], mToolbarContainer.getWidth(),
+ mTempPosition[1] + mToolbar.getHeight());
+
+ mToolbar.getLocationBarContentRect(mLocationBarRect);
+ mLocationBarRect.offset(mTempPosition[0], mTempPosition[1]);
+
+ int shadowHeight =
+ mToolbarContainer.getHeight() - mToolbar.getHeight() - mTabStripHeightPx;
+ return ResourceFactory.createToolbarContainerResource(
+ mToolbarRect, mLocationBarRect, shadowHeight);
}
}

Powered by Google App Engine
This is Rietveld 408576698