Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/resources/ResourceFactory.java

Issue 2752693003: chrome/android: Update toolbar drawing in native. (Closed)
Patch Set: fix math for tablets Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.chrome.browser.compositor.resources;
6
7 import android.graphics.Rect;
8
9 import org.chromium.base.annotations.JNINamespace;
10
11 /**
12 * Utility class for creating native resources.
13 */
14 @JNINamespace("android")
15 public class ResourceFactory {
16 public static long createToolbarContainerResource(
mdjones 2017/03/16 21:01:47 Are we going to do something similar for the crush
David Trainor- moved to gerrit 2017/03/17 07:41:22 I think that (crushed sprite) could go in ui/ sinc
mdjones 2017/03/17 15:38:10 That makes sense, I was thinking about it as part
Khushal 2017/03/17 23:02:58 Yeah. CrushedSprite in next patch. That should be
Khushal 2017/03/17 23:49:44 I looked at CrushedSprite and they are funkier tha
17 Rect toolbarPosition, Rect locationBarPosition, int shadowHeight) {
18 return nativeCreateToolbarContainerResource(toolbarPosition.left, toolba rPosition.top,
19 toolbarPosition.right, toolbarPosition.bottom, locationBarPositi on.left,
20 locationBarPosition.top, locationBarPosition.right, locationBarP osition.bottom,
21 shadowHeight);
22 }
23
24 private static native long nativeCreateToolbarContainerResource(int toolbarL eft, int toolbarTop,
25 int toolbarRight, int toolbarBottom, int locationBarLeft, int locati onBarTop,
26 int locationBarRight, int locationBarBottom, int shadowHeight);
27 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698