Stop showing snackbar with success message when sharing with Chrome iOS.

ios/chrome/browser/ui/activity_services/activity_type_util.mm

Index: ios/chrome/browser/ui/activity_services/activity_type_util.mm
diff --git a/ios/chrome/browser/ui/activity_services/activity_type_util.mm b/ios/chrome/browser/ui/activity_services/activity_type_util.mm
index 0675a00194ccd24d7cd6dc1547220e2c046da557..67e0c88ced0fb76e14f67145b9eb3019f9b47dbf 100644
--- a/ios/chrome/browser/ui/activity_services/activity_type_util.mm
+++ b/ios/chrome/browser/ui/activity_services/activity_type_util.mm
@@ -104,22 +104,13 @@ bool IsPasswordAppExActivity(NSString* activityString) {
   return PasswordAppExActivityVersion(activityString) != nil;
 }
 
-NSString* SuccessMessageForActivity(ActivityType type) {
+NSString* CompletionMessageForActivity(ActivityType type) {
+  // Be careful when adding messages for activites: for many activities the fact
+  // that the sharing was reported as completed does not imply that the sharing
+  // was successful.

[pkl (ping after 24h if needed), 2017/03/14 21:13:34]

Suggestion on improving the readability of this:
"For some activities, they can be reported as completed even if not
successfully.
Make sure that the message is meaningful even if the activity completed
unsuccessfully."

[jif, 2017/03/15 10:41:18]

This is much much better indeed.
Good thing I'm going to "Tech Writing 101" on friday!

Note that I changed the first sentence to:
// Some activities can be reported as completed even if not successful.

   switch (type) {
     case NATIVE_CLIPBOARD:
       return l10n_util::GetNSString(IDS_IOS_SHARE_TO_CLIPBOARD_SUCCESS);
-    case NATIVE_FACEBOOK:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_FACEBOOK_COMPLETE);
-    case NATIVE_MAIL:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_EMAIL_COMPLETE);
-    case NATIVE_MESSAGE:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_MESSAGES_COMPLETE);
-    case NATIVE_TWITTER:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_TWITTER_COMPLETE);
-    case GOOGLE_GMAIL:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_EMAIL_COMPLETE);
-    case GOOGLE_GOOGLEPLUS:
-      return l10n_util::GetNSString(IDS_IOS_SHARE_GPLUS_COMPLETE);
     case APPEX_PASSWORD_MANAGEMENT_1PASSWORD:
     case APPEX_PASSWORD_MANAGEMENT_LASTPASS:
     case APPEX_PASSWORD_MANAGEMENT_DASHLANE: