third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2752623002: Return '' for overflow if overflow-x and overflow-y are different.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2752623002: Return '' for overflow if overflow-x and overflow-y are different. (Closed)

Patch Set: Address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/different-overflow-x-and-y.html ('K') | « third_party/WebKit/LayoutTests/fast/css/different-overflow-x-and-y.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 6227c6d6293da1a0824d170335fb272c5a04f007..ebd40192b3f71849be1e8ae3cafa0d1d67c0e4d0 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2666,8 +2666,9 @@ const CSSValue* ComputedStyleCSSValueMapping::get(

case CSSPropertyOutlineWidth:

return zoomAdjustedPixelValue(style.outlineWidth(), style);

case CSSPropertyOverflow:

- return CSSIdentifierValue::create(

- max(style.overflowX(), style.overflowY()));

+ if (style.overflowX() == style.overflowY())

+ return CSSIdentifierValue::create(style.overflowX());

+ return nullptr;

case CSSPropertyOverflowAnchor:

return CSSIdentifierValue::create(style.overflowAnchor());

case CSSPropertyOverflowWrap: