content/browser/download/download_job.cc - Issue 2752603002: Propagate server response error and interrupt the download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_job.cc

Issue 2752603002: Propagate server response error and interrupt the download. (Closed)

Patch Set: Work on feedbacks. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_job.cc

diff --git a/content/browser/download/download_job.cc b/content/browser/download/download_job.cc

index 4da7eb429ae6eca4a6b880e8924dbe5f79e7a054..1e73c8683cb3e9879d344e6ed79c4ca8ca7b9a87 100644

--- a/content/browser/download/download_job.cc

+++ b/content/browser/download/download_job.cc

@@ -25,4 +25,8 @@ void DownloadJob::StartDownload() const {

download_item_->StartDownload();

}

+void DownloadJob::Interrupt(DownloadInterruptReason reason) {

+ download_item_->InterruptAndDiscardPartialState(reason);

qinmin 2017/03/17 05:09:46 This doesn't update the download_item_'s observers

xingliu 2017/03/17 21:14:36 Done, thanks for this suggestion.

} // namespace content