Propagate server response error and interrupt the download.

content/browser/download/download_worker.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_worker.h"
 
 #include "content/browser/download/download_create_info.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/web_contents.h"
 
@@ skipping 20 matching lines @@
 }
 
 }  // namespace
 
 DownloadWorker::DownloadWorker(DownloadWorker::Delegate* delegate,
                                int64_t offset,
                                int64_t length)
     : delegate_(delegate),
       offset_(offset),
       length_(length),
-      weak_factory_(this) {}
+      weak_factory_(this) {
+  DCHECK(delegate_);
+}
 
 DownloadWorker::~DownloadWorker() = default;
 
 void DownloadWorker::SendRequest(
     std::unique_ptr<DownloadUrlParameters> params) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   BrowserThread::PostTaskAndReplyWithResult(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&CreateUrlDownloader, base::Passed(&params),
                  weak_factory_.GetWeakPtr()),
       base::Bind(&DownloadWorker::AddUrlDownloader,
                  weak_factory_.GetWeakPtr()));
 }
 
 void DownloadWorker::Pause() {
-  request_handle_->PauseRequest();
+  if (request_handle_)
+    request_handle_->PauseRequest();
 }
 
 void DownloadWorker::Resume() {
-  request_handle_->ResumeRequest();
+  if (request_handle_)
+    request_handle_->ResumeRequest();
 }
 
 void DownloadWorker::Cancel() {
-  request_handle_->CancelRequest();
+  if (request_handle_)
+    request_handle_->CancelRequest();
 }
 
 void DownloadWorker::OnUrlDownloaderStarted(
     std::unique_ptr<DownloadCreateInfo> create_info,
     std::unique_ptr<ByteStreamReader> stream_reader,
     const DownloadUrlParameters::OnStartedCallback& callback) {
   // |callback| is not used in subsequent requests.
   DCHECK(callback.is_null());
 
-  // TODO(xingliu): Pass the |stream_reader| to parallel job and handle failed
-  // request.
+  // TODO(xingliu): Add the interrupt reason and metric data for precondition
+  // failure. Make DownloadRequestCore know if it should return error if the
+  // the server gives a different part of the content, e.g. "If-Match" return
+  // http 200.
   if (create_info->result !=
       DownloadInterruptReason::DOWNLOAD_INTERRUPT_REASON_NONE) {
-    VLOG(kVerboseLevel) << "Parallel download sub request failed. reason = "
+    VLOG(kVerboseLevel) << "Parallel download sub-request failed. reason = "
                         << create_info->result;
-    NOTIMPLEMENTED();
+    delegate_->OnServerResponseError(this, create_info->result);
     return;
   }
 
   request_handle_ = std::move(create_info->request_handle);
   if (delegate_)
     delegate_->OnByteStreamReady(this, std::move(stream_reader));
 }
 
 void DownloadWorker::OnUrlDownloaderStopped(UrlDownloader* downloader) {
   // Release the |url_downloader_|, the object will be deleted on IO thread.
   url_downloader_.reset();
 }
 
 void DownloadWorker::AddUrlDownloader(
     std::unique_ptr<UrlDownloader, BrowserThread::DeleteOnIOThread>
         downloader) {
   url_downloader_ = std::move(downloader);
 }
 
 }  // namespace content