cc/playback/display_item_list_unittest.cc - Issue 2752593002: cc: Make PaintCanvas abstract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/playback/display_item_list_unittest.cc

Issue 2752593002: cc: Make PaintCanvas abstract (Closed)

Patch Set: Separate files Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/paint/skia_paint_canvas.cc ('k') | cc/resources/video_resource_updater.cc » ('j') | content/renderer/pepper/pepper_graphics_2d_host_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/playback/display_item_list_unittest.cc

diff --git a/cc/playback/display_item_list_unittest.cc b/cc/playback/display_item_list_unittest.cc

index 426371e6bd85935cfe107fa7c958243eab78952d..4fb78e64fd53921aea3c2e2c537dcdcce6a41ebe 100644

--- a/cc/playback/display_item_list_unittest.cc

+++ b/cc/playback/display_item_list_unittest.cc

@@ -96,7 +96,7 @@ TEST(DisplayItemListTest, SingleDrawingItem) {

SkImageInfo info =

SkImageInfo::MakeN32Premul(layer_rect.width(), layer_rect.height());

expected_bitmap.installPixels(info, expected_pixels, info.minRowBytes());

- PaintCanvas expected_canvas(expected_bitmap);

+ SkiaPaintCanvas expected_canvas(expected_bitmap);

expected_canvas.clipRect(gfx::RectToSkRect(layer_rect));

expected_canvas.drawRect(

SkRect::MakeLTRB(0.f + offset.x(), 0.f + offset.y(), 60.f + offset.x(),

@@ -152,7 +152,7 @@ TEST(DisplayItemListTest, ClipItem) {

SkImageInfo info =

SkImageInfo::MakeN32Premul(layer_rect.width(), layer_rect.height());

expected_bitmap.installPixels(info, expected_pixels, info.minRowBytes());

- PaintCanvas expected_canvas(expected_bitmap);

+ SkiaPaintCanvas expected_canvas(expected_bitmap);

expected_canvas.clipRect(gfx::RectToSkRect(layer_rect));

expected_canvas.drawRect(

SkRect::MakeLTRB(0.f + first_offset.x(), 0.f + first_offset.y(),

@@ -209,7 +209,7 @@ TEST(DisplayItemListTest, TransformItem) {

SkImageInfo info =

SkImageInfo::MakeN32Premul(layer_rect.width(), layer_rect.height());

expected_bitmap.installPixels(info, expected_pixels, info.minRowBytes());

- PaintCanvas expected_canvas(expected_bitmap);

+ SkiaPaintCanvas expected_canvas(expected_bitmap);

expected_canvas.clipRect(gfx::RectToSkRect(layer_rect));

expected_canvas.drawRect(

SkRect::MakeLTRB(0.f + first_offset.x(), 0.f + first_offset.y(),

@@ -282,7 +282,7 @@ TEST(DisplayItemListTest, FilterItem) {

SkImageInfo info =

SkImageInfo::MakeN32Premul(layer_rect.width(), layer_rect.height());

expected_bitmap.installPixels(info, expected_pixels, info.minRowBytes());

- PaintCanvas expected_canvas(expected_bitmap);

+ SkiaPaintCanvas expected_canvas(expected_bitmap);

expected_canvas.drawRect(RectFToSkRect(filter_bounds), paint);

EXPECT_EQ(0, memcmp(pixels, expected_pixels, 4 * 100 * 100));

« no previous file with comments | « cc/paint/skia_paint_canvas.cc ('k') | cc/resources/video_resource_updater.cc » ('j') | content/renderer/pepper/pepper_graphics_2d_host_unittest.cc » ('J')