Parse try-catch statements with Fasta.

Parse try-catch statements with Fasta.

There are still failing tests because we cannot access the comma between
the exception and the stack trace parameters. I will make a change
to Analyzer AST to remember commas in parameters, and send another CL
to use it in AST builder.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f873c5657bf7cfb83983c8839d81e05dd75e9fb2

[Paul Berry, 2017-03-14 19:30:06]

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (left):

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:775: exitLocalScope();
It's not obvious to me why it's safe to drop the call to exitLocalScope().  Did
you remove this by mistake?

[scheglov, 2017-03-14 19:34:42]

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (left):

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:775: exitLocalScope();
On 2017/03/14 19:30:06, Paul Berry wrote:
> It's not obvious to me why it's safe to drop the call to exitLocalScope(). 
Did
> you remove this by mistake?

No, this is an intentional change.
There is no corresponding enterLocalScope() invocation for catch clauses.

[Paul Berry, 2017-03-14 19:39:01]

lgtm

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (left):

https://codereview.chromium.org/2752543005/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:775: exitLocalScope();
On 2017/03/14 19:34:42, scheglov wrote:
> On 2017/03/14 19:30:06, Paul Berry wrote:
> > It's not obvious to me why it's safe to drop the call to exitLocalScope(). 
> Did
> > you remove this by mistake?
> 
> No, this is an intentional change.
> There is no corresponding enterLocalScope() invocation for catch clauses.

Ok, thanks for clarifying.

[scheglov, 2017-03-14 20:03:42]

Description was changed from

==========
Parse try-catch statements with Fasta.

There are still failing tests because we cannot access the comma between
the exception and the stack trace parameters. I will make a change
to Analyzer AST to remember commas in parameters, and send another CL
to use it in AST builder.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Parse try-catch statements with Fasta.

There are still failing tests because we cannot access the comma between
the exception and the stack trace parameters. I will make a change
to Analyzer AST to remember commas in parameters, and send another CL
to use it in AST builder.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f873c5657bf7cfb83983c8839d81e05dd75e9fb2
==========

[scheglov, 2017-03-14 20:03:43]

Committed patchset #2 (id:20001) manually as
f873c5657bf7cfb83983c8839d81e05dd75e9fb2 (presubmit successful).