Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2752483002: Search the entire subtree when looking for the end of an inline continuation chain. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp
index 0ca9f0c68c9b5df3ea98a2f5e951b0b7f8a226a5..6992af87ed788db430c335b0b0f57aac83a045ff 100644
--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp
@@ -1140,11 +1140,17 @@ LayoutRect LayoutInline::absoluteVisualRect() const {
for (LayoutBlock* currBlock = containingBlock();
currBlock && currBlock->isAnonymousBlock();
currBlock = toLayoutBlock(currBlock->nextSibling())) {
+ bool walkChildrenOnly = !currBlock->childrenInline();
for (LayoutObject* curr = currBlock->firstChild(); curr;
curr = curr->nextSibling()) {
LayoutRect rect(curr->localVisualRect());
context(FloatRect(rect));
- if (curr == endContinuation) {
+ if (walkChildrenOnly)
+ continue;
+ for (LayoutObject* walker = curr; walker;
+ walker = walker->nextInPreOrder(curr)) {
+ if (walker != endContinuation)
+ continue;
LayoutRect rect(enclosingIntRect(floatResult));
mapToVisualRectInAncestorSpace(view(), rect);
return rect;
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698