Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 275243003: Ash:Strings - Update quit message to sign out on chrome-os (Closed)

Created:
6 years, 7 months ago by Harry McCleave
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

When using the quit/sign out shortcut (ctrl-shift-q) on chrome-os display the string "... to sign out" instead of "... to quit" BUG=365166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270032

Patch Set 1 #

Patch Set 2 : line length (missed presubmit warning??) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ash/accelerators/exit_warning_handler.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
lgtm
6 years, 7 months ago (2014-05-12 20:06:09 UTC) #1
Harry McCleave
The CQ bit was checked by harrym@chromium.org
6 years, 7 months ago (2014-05-13 04:02:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/275243003/20001
6 years, 7 months ago (2014-05-13 04:02:53 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:39:13 UTC) #4
Message was sent while issue was closed.
Change committed as 270032

Powered by Google App Engine
This is Rietveld 408576698