Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2752423003: Restore weak mode errors on empty returns in Null functions (Closed)

Created:
3 years, 9 months ago by Leaf
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
3 years, 9 months ago (2017-03-17 21:00:58 UTC) #3
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-17 21:23:05 UTC) #4
Leaf
3 years, 9 months ago (2017-03-17 21:31:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e40f878abc807ac2a0bb81bc268aa78a1da642e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698