dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart - Issue 27524003: Generate tear-off closures dynamically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

Issue 27524003: Generate tear-off closures dynamically. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed unit tests. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

index 68cdfa76a53dbe3d35f419bcd1d1f43a452ab34e..fad4b239e6fbd7111281c6b271e98d2a32cdc8c3 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

@@ -70,7 +70,11 @@ class TypeTestEmitter extends CodeEmitterHelper {

RuntimeTypes rti = backend.rti;

jsAst.Expression encoding = rti.getSignatureEncoding(type, thisAccess);

String operatorSignature = namer.operatorSignature();

- builder.addProperty(operatorSignature, encoding);

+ if (!type.containsTypeVariables) {

+ builder.functionType = '${task.metadataEmitter.reifyType(type)}';

+ } else {

+ builder.addProperty(operatorSignature, encoding);

+ }

}

void generateSubstitution(ClassElement cls, {bool emitNull: false}) {