Issue 27524002: DevTools: process trace events from background threads by a timed task.

Issue 27524002: DevTools: process trace events from background threads by a timed task. (Closed)

Created:
7 years, 2 months ago by caseq

Modified:
7 years, 2 months ago

Reviewers:
alph, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: process trace events from background threads by a timed task. We used to process pending background events upon BeginFrame, which was a hack and does not work if main thread frames are not fired. We should post a main thread task upon adding new events instead. BUG=305863 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160160

Patch Set 1 #

Total comments: 1

Patch Set 2 : replaced !Vector::size() with Vector::isEmpty() #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
	M	Source/core/inspector/TimelineTraceEventProcessor.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	Source/core/inspector/TimelineTraceEventProcessor.cpp	View	1	6 chunks	+24 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alph

https://codereview.chromium.org/27524002/diff/1/Source/core/inspector/TimelineTraceEventProcessor.cpp File Source/core/inspector/TimelineTraceEventProcessor.cpp (right): https://codereview.chromium.org/27524002/diff/1/Source/core/inspector/TimelineTraceEventProcessor.cpp#newcode437 Source/core/inspector/TimelineTraceEventProcessor.cpp:437: if (!m_backgroundEvents.size()) nit: isEmpty()

7 years, 2 months ago (2013-10-16 15:22:22 UTC) #2

caseq

On 2013/10/16 15:22:22, alph wrote: > https://codereview.chromium.org/27524002/diff/1/Source/core/inspector/TimelineTraceEventProcessor.cpp > File Source/core/inspector/TimelineTraceEventProcessor.cpp (right): > > https://codereview.chromium.org/27524002/diff/1/Source/core/inspector/TimelineTraceEventProcessor.cpp#newcode437 > ...

7 years, 2 months ago (2013-10-16 15:40:29 UTC) #3

pfeldman

lgtm https://codereview.chromium.org/27524002/diff/6001/Source/core/inspector/TimelineTraceEventProcessor.cpp File Source/core/inspector/TimelineTraceEventProcessor.cpp (right): https://codereview.chromium.org/27524002/diff/6001/Source/core/inspector/TimelineTraceEventProcessor.cpp#newcode231 Source/core/inspector/TimelineTraceEventProcessor.cpp:231: const float EventProcessingThresholdInSeconds = 0.1; eventProcessingThresholdInSeconds

7 years, 2 months ago (2013-10-17 17:19:22 UTC) #4

caseq

7 years, 2 months ago (2013-10-22 09:02:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r160160 (presubmit successful).

Expand Messages | Collapse Messages