DevTools: more efficiently dispose messages on console clear

third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
       this._name = url;
     }
 
     this._contentType = contentType;
     /** @type {?Promise<?string>} */
     this._requestContentPromise = null;
     /** @type {?Multimap<string, !Workspace.UISourceCode.LineMarker>} */
     this._decorations = null;
     /** @type {?Array.<!Workspace.Revision>} */
     this._history = null;
-    /** @type {?Array<!Workspace.UISourceCode.Message>} */
+    /** @type {?Set<!Workspace.UISourceCode.Message>} */
     this._messages = null;
     this._contentLoaded = false;
     /** @type {?string} */
     this._content = null;
     this._forceLoadOnCheckContent = false;
     this._checkingContent = false;
     /** @type {?string} */
     this._lastAcceptedContent = null;
     /** @type {?string} */
     this._workingCopy = null;
@@ skipping 442 matching lines @@
    * @param {number=} columnNumber
    * @return {!Workspace.UILocation}
    */
   uiLocation(lineNumber, columnNumber) {
     if (typeof columnNumber === 'undefined')
       columnNumber = 0;
     return new Workspace.UILocation(this, lineNumber, columnNumber);
   }
 
   /**
-   * @return {!Array<!Workspace.UISourceCode.Message>}
+   * @return {!Set<!Workspace.UISourceCode.Message>}
    */
   messages() {
-    return this._messages ? this._messages.slice() : [];
+    return this._messages ? new Set(this._messages) : new Set();
   }
 
   /**
    * @param {!Workspace.UISourceCode.Message.Level} level
    * @param {string} text
    * @param {number} lineNumber
    * @param {number=} columnNumber
    * @return {!Workspace.UISourceCode.Message} message
    */
   addLineMessage(level, text, lineNumber, columnNumber) {
     return this.addMessage(
         level, text, new Common.TextRange(lineNumber, columnNumber || 0, lineNumber, columnNumber || 0));
   }
 
   /**
    * @param {!Workspace.UISourceCode.Message.Level} level
    * @param {string} text
    * @param {!Common.TextRange} range
    * @return {!Workspace.UISourceCode.Message} message
    */
   addMessage(level, text, range) {
     var message = new Workspace.UISourceCode.Message(this, level, text, range);
     if (!this._messages)
-      this._messages = [];
-    this._messages.push(message);
+      this._messages = new Set();
+    this._messages.add(message);
     this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageAdded, message);
     return message;
   }
 
   /**
    * @param {!Workspace.UISourceCode.Message} message
    */
   removeMessage(message) {
-    if (this._messages && this._messages.remove(message))
+    if (this._messages && this._messages.delete(message))
       this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageRemoved, message);
   }
 
   _removeAllMessages() {
     if (!this._messages)
       return;
     for (var message of this._messages)
       this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageRemoved, message);
     this._messages = null;
   }
@@ skipping 344 matching lines @@
 Workspace.UISourceCodeMetadata = class {
   /**
    * @param {?Date} modificationTime
    * @param {?number} contentSize
    */
   constructor(modificationTime, contentSize) {
     this.modificationTime = modificationTime;
     this.contentSize = contentSize;
   }
 };