DevTools: more efficiently dispose messages on console clear

third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 544 matching lines @@
       this._messages = [];
     this._messages.push(message);
     this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageAdded, message);
     return message;
   }
 
   /**
    * @param {!Workspace.UISourceCode.Message} message
    */
   removeMessage(message) {
     if (this._messages && this._messages.remove(message))

[lushnikov, 2017/03/17 01:29:05]

let's rather have this._messages a set

[luoe, 2017/03/17 18:33:00]

Done.

       this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageRemoved, message);
   }
 
+  /**
+   * @param {!Set<!Workspace.UISourceCode.Message>} messagesToRemove
+   */
+  removeMessages(messagesToRemove) {
+    var remainingMessages = this._messages.filter(message => {
+      var keep = !messagesToRemove.has(message);
+      if (!keep)
+        this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageRemoved, message);
+      return keep;
+    });
+    this._messages = remainingMessages;
+  }
+
   _removeAllMessages() {
     if (!this._messages)
       return;
     for (var message of this._messages)
       this.dispatchEventToListeners(Workspace.UISourceCode.Events.MessageRemoved, message);
     this._messages = null;
   }
 
   /**
    * @param {number} lineNumber
@@ skipping 341 matching lines @@
 Workspace.UISourceCodeMetadata = class {
   /**
    * @param {?Date} modificationTime
    * @param {?number} contentSize
    */
   constructor(modificationTime, contentSize) {
     this.modificationTime = modificationTime;
     this.contentSize = contentSize;
   }
 };