DevTools: more efficiently dispose messages on console clear

third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 137 matching lines @@
     }
 
     if (pendingMessages.length)
       this._pendingConsoleMessages[script.sourceURL] = pendingMessages;
     else
       delete this._pendingConsoleMessages[script.sourceURL];
   }
 
   _consoleCleared() {
     this._pendingConsoleMessages = {};
-    for (var i = 0; i < this._presentationConsoleMessages.length; ++i)
-      this._presentationConsoleMessages[i].dispose();
+
+    var messageUISourceCodes = new Set();
+    var uiMessagesToRemove = new Set();
+    for (var i = 0; i < this._presentationConsoleMessages.length; ++i) {
+      var uiMessage = this._presentationConsoleMessages[i].uiMessage();
+      if (uiMessage) {
+        messageUISourceCodes.add(uiMessage.uiSourceCode());
+        uiMessagesToRemove.add(uiMessage);
+      }
+    }
+
+    for (var uiSourceCode of messageUISourceCodes)
+      uiSourceCode.removeMessages(uiMessagesToRemove);
+
     this._presentationConsoleMessages = [];
     this._locationPool.disposeAll();
   }
 
   _debuggerReset() {
     this._consoleCleared();
   }
 };
 
 /**
  * @unrestricted
  */
 Bindings.PresentationConsoleMessage = class {
   /**
    * @param {!SDK.ConsoleMessage} message
    * @param {!SDK.DebuggerModel.Location} rawLocation
    * @param {!Bindings.LiveLocationPool} locationPool
    */
   constructor(message, rawLocation, locationPool) {
     this._text = message.messageText;
     this._level = message.level === SDK.ConsoleMessage.MessageLevel.Error ?
         Workspace.UISourceCode.Message.Level.Error :
         Workspace.UISourceCode.Message.Level.Warning;
     Bindings.debuggerWorkspaceBinding.createLiveLocation(rawLocation, this._updateLocation.bind(this), locationPool);
+
+    /** @type {!Workspace.UISourceCode.Message|undefined} */
+    this._uiMessage;
   }
 
   /**
    * @param {!Bindings.LiveLocation} liveLocation
    */
   _updateLocation(liveLocation) {
     if (this._uiMessage)
       this._uiMessage.remove();
     var uiLocation = liveLocation.uiLocation();
     if (!uiLocation)
       return;
     this._uiMessage =
         uiLocation.uiSourceCode.addLineMessage(this._level, this._text, uiLocation.lineNumber, uiLocation.columnNumber);
   }
 
-  dispose() {
-    if (this._uiMessage)
-      this._uiMessage.remove();
+  /**
+   * @return {!Workspace.UISourceCode.Message|undefined}
+   */
+  uiMessage() {
+    return this._uiMessage;
   }
 };
 
 /** @type {!Bindings.PresentationConsoleMessageHelper} */
 Bindings.presentationConsoleMessageHelper;