Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 275233004: Move language_detection to core (Closed)

Created:
6 years, 7 months ago by nshaik
Modified:
6 years, 7 months ago
Reviewers:
droger, blundell
CC:
chromium-reviews, MAD, Takashi Toyoshima, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move language_detection to core components/translate/language_detection should be moved to components/translate/core/language_detection, since this code is shared by iOS and other platforms. BUG=331780 TEST=components_unittests --gtest_filter=LanguageDetection* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270248

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated as per review comments #

Total comments: 2

Patch Set 3 : Fixed Alphabetical order #

Patch Set 4 : Adding TBR=jam@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -625 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/translate.gypi View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + components/translate/core/language_detection/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/translate/core/language_detection/language_detection_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/translate/core/language_detection/language_detection_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/translate/core/language_detection/language_detection_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/translate/language_detection/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/translate/language_detection/language_detection_util.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/translate/language_detection/language_detection_util.cc View 1 chunk +0 lines, -389 lines 0 comments Download
D components/translate/language_detection/language_detection_util_unittest.cc View 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nshaik
Kindly review, Thanks.
6 years, 7 months ago (2014-05-10 13:49:33 UTC) #1
blundell
Looks good, very clean! Moving the other reviewers to CC and adding droger@. David's LG ...
6 years, 7 months ago (2014-05-12 07:58:44 UTC) #2
nshaik
Fixed the gypi target name https://codereview.chromium.org/275233004/diff/1/components/translate.gypi File components/translate.gypi (right): https://codereview.chromium.org/275233004/diff/1/components/translate.gypi#newcode83 components/translate.gypi:83: 'target_name': 'translate_language_detection', On 2014/05/12 ...
6 years, 7 months ago (2014-05-13 05:52:25 UTC) #3
droger
Thanks! Translate LGTM https://codereview.chromium.org/275233004/diff/20001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/275233004/diff/20001/AUTHORS#newcode410 AUTHORS:410: Naiem Shaik <naiem.shaik@gmail.com> Please keep this ...
6 years, 7 months ago (2014-05-13 06:28:03 UTC) #4
nshaik
Fixed the authors file https://codereview.chromium.org/275233004/diff/20001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/275233004/diff/20001/AUTHORS#newcode410 AUTHORS:410: Naiem Shaik <naiem.shaik@gmail.com> On 2014/05/13 ...
6 years, 7 months ago (2014-05-13 16:14:36 UTC) #5
blundell
LGTM I assume you filled out the online CLA? You can TBR jam@chromium.org for the ...
6 years, 7 months ago (2014-05-13 18:59:44 UTC) #6
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 7 months ago (2014-05-13 20:05:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/275233004/60001
6 years, 7 months ago (2014-05-13 20:06:54 UTC) #8
nshaik
On 2014/05/13 18:59:44, blundell wrote: > LGTM > > I assume you filled out the ...
6 years, 7 months ago (2014-05-13 20:07:16 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 23:45:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 270248

Powered by Google App Engine
This is Rietveld 408576698