Chromium Code Reviews| Index: media/blink/webaudiosourceprovider_impl.cc |
| diff --git a/media/blink/webaudiosourceprovider_impl.cc b/media/blink/webaudiosourceprovider_impl.cc |
| index 825bd5169fdd9fcec5979ca35cc92b03f5eb8dd9..ff9fc890e4efc9c27a5337f527ceeef359d1c3f3 100644 |
| --- a/media/blink/webaudiosourceprovider_impl.cc |
| +++ b/media/blink/webaudiosourceprovider_impl.cc |
| @@ -253,8 +253,18 @@ bool WebAudioSourceProviderImpl::SetVolume(double volume) { |
| OutputDeviceInfo WebAudioSourceProviderImpl::GetOutputDeviceInfo() { |
| base::AutoLock auto_lock(sink_lock_); |
| - return sink_ ? sink_->GetOutputDeviceInfo() |
| - : OutputDeviceInfo(OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND); |
| + OutputDeviceInfo info; |
| + |
| + if (sink_) { |
| + info = sink_->GetOutputDeviceInfo(); |
|
DaleCurtis
2017/04/06 19:44:42
Instead of returning the true sink parameters when
flim-chromium
2017/04/07 22:01:43
It looks like the |client_| params are set only in
DaleCurtis
2017/04/10 19:38:51
Yes, that's how it works today, but I think we ne
Raymond Toy
2017/04/11 21:51:38
That's probably the right thing to do because some
|
| + if (client_) { |
| + info.SetIsWebAudioSource(true); |
| + } |
| + } else { |
| + info = OutputDeviceInfo(OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND); |
| + } |
| + |
| + return info; |
| } |
| bool WebAudioSourceProviderImpl::CurrentThreadIsRenderingThread() { |