Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2469)

Unified Diff: chrome/browser/resources/md_bookmarks/actions.js

Issue 2752223004: MD Bookmarks: Remove deleted nodes from state tree (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/actions.js
diff --git a/chrome/browser/resources/md_bookmarks/actions.js b/chrome/browser/resources/md_bookmarks/actions.js
index 62a0ba82994ce578970a535b3acf4482ec4387d2..5a71f7e462196a885d6e05335b0272b0c9cfe6b0 100644
--- a/chrome/browser/resources/md_bookmarks/actions.js
+++ b/chrome/browser/resources/md_bookmarks/actions.js
@@ -44,12 +44,15 @@ cr.define('bookmarks.actions', function() {
* @param {string} id
* @param {string} parentId
* @param {number} index
+ * @param {NodeList} nodes
* @return {!Action}
*/
- function removeBookmark(id, parentId, index) {
+ function removeBookmark(id, parentId, index, nodes) {
tsergeant 2017/03/23 05:36:07 My intention is still that actions should be able
+ var descendants = bookmarks.util.getDescendants(nodes, id);
return {
name: 'remove-bookmark',
id: id,
+ descendants: descendants,
parentId: parentId,
index: index,
};

Powered by Google App Engine
This is Rietveld 408576698