Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4167)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_subpage.js

Issue 2752223003: MD Settings: Fix Network section styling (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_subpage.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_subpage.js b/chrome/browser/resources/settings/internet_page/internet_subpage.js
index 24c3483b18789144f5a9d60612857bb7a61f1159..09126808346835c5477444754114bf93f52ec287 100644
--- a/chrome/browser/resources/settings/internet_page/internet_subpage.js
+++ b/chrome/browser/resources/settings/internet_page/internet_subpage.js
@@ -29,9 +29,12 @@ Polymer({
/**
* Device state for the network type.
- * @type {?DeviceStateProperties|undefined}
+ * @type {?DeviceStateProperties}
*/
- deviceState: Object,
+ deviceState: {
+ type: Object,
+ value: null,
+ },
/** @type {!chrome.networkingPrivate.GlobalPolicy|undefined} */
globalPolicy: Object,
@@ -175,6 +178,8 @@ Polymer({
configured: false
};
this.networkingPrivate.getNetworks(filter, function(networkStates) {
+ if (!this.deviceState)
+ return;
if (this.deviceState.Type != CrOnc.Type.VPN) {
this.networkStateList_ = networkStates;
return;
@@ -294,6 +299,7 @@ Polymer({
/** @private */
onAddButtonTap_: function() {
+ assert(this.deviceState);
chrome.send('addNetwork', [this.deviceState.Type]);
},

Powered by Google App Engine
This is Rietveld 408576698