Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2752223003: MD Settings: Fix Network section styling (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index 66f461924d467705410b2158d9a50a38ef160bba..9b876112479edf5d2e8c6421d952384396b6ce72 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -113,6 +113,12 @@ Polymer({
/** @private */
advancedExpanded_: Boolean,
+ /** @private */
+ networkExpanded_: Boolean,
+
+ /** @private */
+ proxyExpanded_: Boolean,
+
/**
* Object providing network type values for data binding.
* @const
@@ -531,17 +537,39 @@ Polymer({
this.networkingPrivate.startActivate(this.guid);
},
+ /** @const {string} */ CR_EXPAND_BUTTON_TAG: 'CR-EXPAND-BUTTON',
+
/**
* @param {Event} event
* @private
*/
toggleAdvancedExpanded_: function(event) {
- if (event.target.id == 'expandButton')
+ if (event.target.tagName == this.CR_EXPAND_BUTTON_TAG)
return; // Already handled.
this.advancedExpanded_ = !this.advancedExpanded_;
},
/**
+ * @param {Event} event
+ * @private
+ */
+ toggleNetworkExpanded_: function(event) {
+ if (event.target.tagName == this.CR_EXPAND_BUTTON_TAG)
+ return; // Already handled.
+ this.networkExpanded_ = !this.networkExpanded_;
+ },
+
+ /**
+ * @param {Event} event
+ * @private
+ */
+ toggleProxyExpanded_: function(event) {
+ if (event.target.tagName == this.CR_EXPAND_BUTTON_TAG)
+ return; // Already handled.
+ this.proxyExpanded_ = !this.proxyExpanded_;
+ },
+
+ /**
* Event triggered for elements associated with network properties.
* @param {!{detail: !{field: string, value: (string|!Object)}}} event
* @private
@@ -840,13 +868,13 @@ Polymer({
/**
* @param {!CrOnc.NetworkProperties} networkProperties
- * @return {boolean} True if the network section should be shown.
+ * @return {boolean}
* @private
*/
hasNetworkSection_: function(networkProperties) {
- if (this.networkProperties.Type == CrOnc.Type.VPN)
+ if (networkProperties.Type == CrOnc.Type.VPN)
return false;
- if (this.networkProperties.Type == CrOnc.Type.CELLULAR)
+ if (networkProperties.Type == CrOnc.Type.CELLULAR)
return true;
return this.isRememberedOrConnected_(networkProperties);
},

Powered by Google App Engine
This is Rietveld 408576698