chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2752223003: MD Settings: Fix Network section styling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2752223003: MD Settings: Fix Network section styling (Closed)

Patch Set: Fix third party vpn visibility Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_proxy.html ('K') | « chrome/browser/resources/settings/internet_page/network_summary_item.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 3e659775da6489d206e5e962574bd9b01b4f6338..c4c112a395384f30ed57b7a248d9347a4840f33b 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -905,11 +905,15 @@ void AddInternetStrings(content::WebUIDataSource* html_source) {

{"networkSectionAdvanced",

IDS_SETTINGS_INTERNET_NETWORK_SECTION_ADVANCED},

{"networkSectionAdvancedExpandA11yLabel",

dschuyler 2017/03/20 19:11:31 Would it make sense to s/Expand// here? I'm not su

stevenjb 2017/03/24 21:00:03 Sure. Done.

- IDS_SETTINGS_INTERNET_NETWORK_SECTION_EXPAND_ACCESSIBILITY_LABEL},

+ IDS_SETTINGS_INTERNET_NETWORK_SECTION_ADVANCED_ACCESSIBILITY_LABEL},

{"networkSectionNameservers",

IDS_SETTINGS_INTERNET_NETWORK_SECTION_NAMESERVERS},

{"networkSectionNetwork", IDS_SETTINGS_INTERNET_NETWORK_SECTION_NETWORK},

+ {"networkSectionNetworkExpandA11yLabel",

+ IDS_SETTINGS_INTERNET_NETWORK_SECTION_NETWORK_ACCESSIBILITY_LABEL},

{"networkSectionProxy", IDS_SETTINGS_INTERNET_NETWORK_SECTION_PROXY},

+ {"networkSectionProxyExpandA11yLabel",

+ IDS_SETTINGS_INTERNET_NETWORK_SECTION_PROXY_ACCESSIBILITY_LABEL},

{"networkSectionWpad", IDS_SETTINGS_INTERNET_NETWORK_SECTION_WPAD},

{"networkShared", IDS_SETTINGS_INTERNET_NETWORK_SHARED},

{"networkSimCardLocked", IDS_SETTINGS_INTERNET_NETWORK_SIM_CARD_LOCKED},