MD Settings: Fix Network section styling

chrome/browser/resources/settings/internet_page/internet_detail_page.js

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index 66f461924d467705410b2158d9a50a38ef160bba..fbe18e09f4f639a8375ebe5d65bd53c6ee15a690 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -113,6 +113,12 @@ Polymer({
     /** @private */
     advancedExpanded_: Boolean,
 
+    /** @private */
+    networkExpanded_: Boolean,
+
+    /** @private */
+    proxyExpanded_: Boolean,
+
     /**
      * Object providing network type values for data binding.
      * @const
@@ -536,12 +542,32 @@ Polymer({
    * @private
    */
   toggleAdvancedExpanded_: function(event) {
-    if (event.target.id == 'expandButton')
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')
       return;  // Already handled.
     this.advancedExpanded_ = !this.advancedExpanded_;
   },
 
   /**
+   * @param {Event} event
+   * @private
+   */
+  toggleNetworkExpanded_: function(event) {
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')
+      return;  // Already handled.
+    this.networkExpanded_ = !this.networkExpanded_;
+  },
+
+  /**
+   * @param {Event} event
+   * @private
+   */
+  toggleProxyExpanded_: function(event) {
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')

[dschuyler, 2017/03/20 19:11:30]

Now that there are three+ uses of this string constant, let's make a const var
for it.

[stevenjb, 2017/03/24 21:00:03]

Pretty much every use I could find of tagName uses a raw string. It's the JS
way! I went ahead and defined a local const member, FWIW.

+      return;  // Already handled.
+    this.proxyExpanded_ = !this.proxyExpanded_;
+  },
+
+  /**
    * Event triggered for elements associated with network properties.
    * @param {!{detail: !{field: string, value: (string|!Object)}}} event
    * @private
@@ -840,13 +866,13 @@ Polymer({
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
-   * @return {boolean} True if the network section should be shown.
+   * @return {boolean}
    * @private
    */
   hasNetworkSection_: function(networkProperties) {
-    if (this.networkProperties.Type == CrOnc.Type.VPN)
+    if (networkProperties.Type == CrOnc.Type.VPN)
       return false;
-    if (this.networkProperties.Type == CrOnc.Type.CELLULAR)
+    if (networkProperties.Type == CrOnc.Type.CELLULAR)
       return true;
     return this.isRememberedOrConnected_(networkProperties);
   },