MD Settings: Fix Network section styling

chrome/browser/resources/settings/internet_page/internet_subpage.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying information about WiFi,
  * WiMAX, or virtual networks.
  */
 
 /** @typedef {chrome.networkingPrivate.DeviceStateProperties} */
@@ skipping 11 matching lines @@
   properties: {
     /**
      * Highest priority connected network or null. Provided by
      * settings-internet-page (but set in network-summary).
      * @type {?CrOnc.NetworkStateProperties|undefined}
      */
     defaultNetwork: Object,
 
     /**
      * Device state for the network type.
      * @type {?DeviceStateProperties|undefined}

[dschuyler, 2017/03/20 19:11:30]

Can this be undefined, or will it either be null or defined?

[stevenjb, 2017/03/24 21:00:03]

Done.

      */
-    deviceState: Object,
+    deviceState: {
+      type: Object,
+      value: null,
+    },
 
     /** @type {!chrome.networkingPrivate.GlobalPolicy|undefined} */
     globalPolicy: Object,
 
     /**
      * List of third party VPN providers.
      * @type
      *     {!Array<!chrome.networkingPrivate.ThirdPartyVPNProperties>|undefined}
      */
     thirdPartyVpnProviders: Array,
@@ skipping 123 matching lines @@
   /** @private */
   getNetworkStateList_: function() {
     if (!this.deviceState)
       return;
     var filter = {
       networkType: this.deviceState.Type,
       visible: true,
       configured: false
     };
     this.networkingPrivate.getNetworks(filter, function(networkStates) {
+      if (!this.deviceState)
+        return;
       if (this.deviceState.Type != CrOnc.Type.VPN) {
         this.networkStateList_ = networkStates;
         return;
       }
       // For VPNs, separate out third party VPNs.
       var networkStateList = [];
       var thirdPartyVpns = {};
       for (var i = 0; i < networkStates.length; ++i) {
         var state = networkStates[i];
         var providerType = state.VPN && state.VPN.ThirdPartyVPN &&
@@ skipping 99 matching lines @@
   showAddButton_: function(deviceState, globalPolicy) {
     if (!deviceState || deviceState.Type != CrOnc.Type.WI_FI)
       return false;
     if (!this.deviceIsEnabled_(deviceState))
       return false;
     return this.allowAddConnection_(globalPolicy);
   },
 
   /** @private */
   onAddButtonTap_: function() {
+    assert(this.deviceState);
     chrome.send('addNetwork', [this.deviceState.Type]);
   },
 
   /**
    * @param {!{model:
    *              !{item: !chrome.networkingPrivate.ThirdPartyVPNProperties},
    *        }} event
    * @private
    */
   onAddThirdPartyVpnTap_: function(event) {
@@ skipping 115 matching lines @@
 
   /**
    * @param {*} lhs
    * @param {*} rhs
    * @return {boolean}
    */
   isEqual_: function(lhs, rhs) {
     return lhs === rhs;
   },
 });