MD Settings: Fix Network section styling

chrome/browser/resources/settings/internet_page/internet_detail_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-detail' is the settings subpage containing details
  * for a network.
  */
 (function() {
@@ skipping 95 matching lines @@
      * @private
      */
     IPAddress_: {
       type: String,
       value: '',
     },
 
     /** @private */
     advancedExpanded_: Boolean,
 
+    /** @private */
+    networkExpanded_: Boolean,
+
+    /** @private */
+    proxyExpanded_: Boolean,
+
     /**
      * Object providing network type values for data binding.
      * @const
      * @private
      */
     NetworkType_: {
       type: Object,
       value: {
         CELLULAR: CrOnc.Type.CELLULAR,
         ETHERNET: CrOnc.Type.ETHERNET,
@@ skipping 403 matching lines @@
   onViewAccountTap_: function() {
     // startActivate() will show the account page for activated networks.
     this.networkingPrivate.startActivate(this.guid);
   },
 
   /**
    * @param {Event} event
    * @private
    */
   toggleAdvancedExpanded_: function(event) {
-    if (event.target.id == 'expandButton')
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')
       return;  // Already handled.
     this.advancedExpanded_ = !this.advancedExpanded_;
   },
 
   /**
+   * @param {Event} event
+   * @private
+   */
+  toggleNetworkExpanded_: function(event) {
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')
+      return;  // Already handled.
+    this.networkExpanded_ = !this.networkExpanded_;
+  },
+
+  /**
+   * @param {Event} event
+   * @private
+   */
+  toggleProxyExpanded_: function(event) {
+    if (event.target.tagName == 'CR-EXPAND-BUTTON')

[dschuyler, 2017/03/20 19:11:30]

Now that there are three+ uses of this string constant, let's make a const var
for it.

[stevenjb, 2017/03/24 21:00:03]

Pretty much every use I could find of tagName uses a raw string. It's the JS
way! I went ahead and defined a local const member, FWIW.

+      return;  // Already handled.
+    this.proxyExpanded_ = !this.proxyExpanded_;
+  },
+
+  /**
    * Event triggered for elements associated with network properties.
    * @param {!{detail: !{field: string, value: (string|!Object)}}} event
    * @private
    */
   onNetworkPropertyChange_: function(event) {
     if (!this.networkProperties)
       return;
     var field = event.detail.field;
     var value = event.detail.value;
     var onc = this.getEmptyNetworkProperties_();
@@ skipping 278 matching lines @@
   /**
    * @return {boolean}
    * @private
    */
   hasAdvancedOrDeviceFields_: function() {
     return this.hasAdvancedFields_() || this.hasDeviceFields_();
   },
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
-   * @return {boolean} True if the network section should be shown.
+   * @return {boolean}
    * @private
    */
   hasNetworkSection_: function(networkProperties) {
-    if (this.networkProperties.Type == CrOnc.Type.VPN)
+    if (networkProperties.Type == CrOnc.Type.VPN)
       return false;
-    if (this.networkProperties.Type == CrOnc.Type.CELLULAR)
+    if (networkProperties.Type == CrOnc.Type.CELLULAR)
       return true;
     return this.isRememberedOrConnected_(networkProperties);
   },
 
   /**
    * @param {string} type The network type.
    * @return {boolean} True if the network type matches 'type'.
    * @private
    */
   isType_: function(type) {
@@ skipping 23 matching lines @@
    */
   allPropertiesMatch_: function(curValue, newValue) {
     for (var key in newValue) {
       if (newValue[key] != curValue[key])
         return false;
     }
     return true;
   }
 });
 })();