Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

Issue 2752223002: bindings: Add the proper includes for unions inside records (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
index 477de5ce8a52c860a559e8fc4e44ee1a78619a40..9c44520231c0d4613846461908a67855d20126ae 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
@@ -72,6 +72,10 @@ def depending_union_type(idl_type):
def find_base_type(current_type):
if current_type.is_array_or_sequence_type:
return find_base_type(current_type.element_type)
+ if current_type.is_record_type:
+ # IdlRecordType.key_type is always a string type, so we only need
+ # to looking into value_type.
+ return find_base_type(current_type.value_type)
if current_type.is_nullable:
return find_base_type(current_type.inner_type)
return current_type
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698