Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2752203005: Correctly track cross-thread pending FetchEvents. (Closed)
Patch Set: add comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 } 83 }
84 84
85 ServiceWorkerGlobalScopeProxy::~ServiceWorkerGlobalScopeProxy() { 85 ServiceWorkerGlobalScopeProxy::~ServiceWorkerGlobalScopeProxy() {
86 // Verify that the proxy has been detached. 86 // Verify that the proxy has been detached.
87 DCHECK(!m_embeddedWorker); 87 DCHECK(!m_embeddedWorker);
88 } 88 }
89 89
90 DEFINE_TRACE(ServiceWorkerGlobalScopeProxy) { 90 DEFINE_TRACE(ServiceWorkerGlobalScopeProxy) {
91 visitor->trace(m_document); 91 visitor->trace(m_document);
92 visitor->trace(m_parentFrameTaskRunners); 92 visitor->trace(m_parentFrameTaskRunners);
93 visitor->trace(m_pendingPreloadFetchEvents);
94 } 93 }
95 94
96 void ServiceWorkerGlobalScopeProxy::setRegistration( 95 void ServiceWorkerGlobalScopeProxy::setRegistration(
97 std::unique_ptr<WebServiceWorkerRegistration::Handle> handle) { 96 std::unique_ptr<WebServiceWorkerRegistration::Handle> handle) {
98 workerGlobalScope()->setRegistration(std::move(handle)); 97 workerGlobalScope()->setRegistration(std::move(handle));
99 } 98 }
100 99
101 void ServiceWorkerGlobalScopeProxy::dispatchActivateEvent(int eventID) { 100 void ServiceWorkerGlobalScopeProxy::dispatchActivateEvent(int eventID) {
102 WaitUntilObserver* observer = WaitUntilObserver::create( 101 WaitUntilObserver* observer = WaitUntilObserver::create(
103 workerGlobalScope(), WaitUntilObserver::Activate, eventID); 102 workerGlobalScope(), WaitUntilObserver::Activate, eventID);
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 return *m_document; 483 return *m_document;
485 } 484 }
486 485
487 ServiceWorkerGlobalScope* ServiceWorkerGlobalScopeProxy::workerGlobalScope() 486 ServiceWorkerGlobalScope* ServiceWorkerGlobalScopeProxy::workerGlobalScope()
488 const { 487 const {
489 DCHECK(m_workerGlobalScope); 488 DCHECK(m_workerGlobalScope);
490 return m_workerGlobalScope; 489 return m_workerGlobalScope;
491 } 490 }
492 491
493 } // namespace blink 492 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698