Add histograms to track the number of job controller and job that are

net/http/http_stream_factory_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl.h"
 
 #include <string>
 #include <tuple>
 
 #include "base/logging.h"
@@ skipping 86 matching lines @@
 
 HttpStreamFactoryImpl::HttpStreamFactoryImpl(HttpNetworkSession* session,
                                              bool for_websockets)
     : session_(session),
       job_factory_(new DefaultJobFactory()),
       for_websockets_(for_websockets) {}
 
 HttpStreamFactoryImpl::~HttpStreamFactoryImpl() {
   DCHECK(request_map_.empty());
   DCHECK(spdy_session_request_map_.empty());
+  size_t alt_job_count = 0;
+  size_t main_job_count = 0;
+  size_t preconnect_controller_count = 0;
+  for (const auto& it : job_controller_set_) {
+    // For a preconnect controller, it should have exactly the main job.
+    if (it->is_preconnect()) {
+      preconnect_controller_count++;
+      continue;
+    }
+    // For non-preconnects.

[xunjieli, 2017/03/17 00:47:56]

Suggest add a DCHECK(it->HasPendingAltJob()||it->HasPendingMainJob()) here to
make sure we won't have JobController hanging around when there aren't any jobs.

[Zhongyi Shi, 2017/03/17 02:02:29]

Done.

+    if (it->HasPendingAltJob())
+      alt_job_count++;
+    if (it->HasPendingMainJob())
+      main_job_count++;
+  }
+  UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfJobController",

[xunjieli, 2017/03/17 00:47:56]

This histogram is not necessary, right?
We can deduce this from the other three. In other words, this histogram should
strictly follow the trend of the other three.

[Zhongyi Shi, 2017/03/17 02:02:29]

Well, that's not exactly true. There might be JobController having both alt job
and main job uncleaned up theoretically. Although we shouldn't run into that
case since all the requests should be handed out to clients.
https://cs.chromium.org/chromium/src/net/http/http_stream_factory_impl.h?l=169

[xunjieli, 2017/03/17 13:05:23]

Right, that's why I suggested using a DCHECK(it->HasPendingAltJob() ||
it->HasPendingMainJob()) so we should catch that unlikely case.

+                          job_controller_set_.size());
+  UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfPreconnect",
+                          preconnect_controller_count);
+  UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfAltJob", alt_job_count);

[xunjieli, 2017/03/17 00:47:56]

For someone who might not know this code, I suggest make a distinction in the
name of the histograms regarding preconnect and nonpreconnect.


"CountOfAltJob" -> "CountOfNonPreconnectAltJob"
"CountOfMainJob" -> "CountOfNonPreconnectMainJob"

[Zhongyi Shi, 2017/03/17 02:02:29]

Done.

+  UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfMainJob",
+                          main_job_count);
 }
 
 HttpStreamRequest* HttpStreamFactoryImpl::RequestStream(
     const HttpRequestInfo& request_info,
     RequestPriority priority,
     const SSLConfig& server_ssl_config,
     const SSLConfig& proxy_ssl_config,
     HttpStreamRequest::Delegate* delegate,
     const NetLogWithSource& net_log) {
   DCHECK(!for_websockets_);
@@ skipping 255 matching lines @@
   factory_dump->AddScalar("main_job_count",
                           base::trace_event::MemoryAllocatorDump::kUnitsObjects,
                           main_job_count);
   // The number of preconnect controllers.
   factory_dump->AddScalar("preconnect_count",
                           base::trace_event::MemoryAllocatorDump::kUnitsObjects,
                           preconnect_controller_count);
 }
 
 }  // namespace net