Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2752153003: Fix incorrect signature in socket.dart. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/io/socket.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
The file runtime/bin/socket_patch.dart says this: void joinMulticast(InternetAddress group, [NetworkInterface interface]) { _socket.joinMulticast(group, interface); } void ...
3 years, 9 months ago (2017-03-16 13:03:59 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 9 months ago (2017-03-16 13:10:25 UTC) #3
ahe
3 years, 9 months ago (2017-03-16 13:28:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b3603878362917a22d74f6fa450f88a7b012cce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698