Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/builtins/builtins-number-gen.cc

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)
Patch Set: tentative gcmole fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-number.cc ('k') | src/builtins/builtins-object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-number-gen.cc
diff --git a/src/builtins/builtins-number.cc b/src/builtins/builtins-number-gen.cc
similarity index 84%
copy from src/builtins/builtins-number.cc
copy to src/builtins/builtins-number-gen.cc
index 0b1afe1b09ea4b868213c30af95483d2b84f5891..767dfea40126a08ff08232b812869323c26ed548 100644
--- a/src/builtins/builtins-number.cc
+++ b/src/builtins/builtins-number-gen.cc
@@ -1,18 +1,17 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
+// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/builtins/builtins-utils.h"
+#include "src/builtins/builtins-utils-gen.h"
#include "src/builtins/builtins.h"
-#include "src/code-factory.h"
#include "src/code-stub-assembler.h"
-#include "src/conversions.h"
-#include "src/counters.h"
-#include "src/objects-inl.h"
namespace v8 {
namespace internal {
+// -----------------------------------------------------------------------------
+// ES6 section 20.1 Number Objects
+
class NumberBuiltinsAssembler : public CodeStubAssembler {
public:
explicit NumberBuiltinsAssembler(compiler::CodeAssemblerState* state)
@@ -50,9 +49,6 @@ class NumberBuiltinsAssembler : public CodeStubAssembler {
}
};
-// -----------------------------------------------------------------------------
-// ES6 section 20.1 Number Objects
-
// ES6 section 20.1.2.2 Number.isFinite ( number )
TF_BUILTIN(NumberIsFinite, CodeStubAssembler) {
Node* number = Parameter(1);
@@ -336,215 +332,6 @@ TF_BUILTIN(NumberParseInt, CodeStubAssembler) {
}
}
-// ES6 section 20.1.3.2 Number.prototype.toExponential ( fractionDigits )
-BUILTIN(NumberPrototypeToExponential) {
- HandleScope scope(isolate);
- Handle<Object> value = args.at(0);
- Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
-
- // Unwrap the receiver {value}.
- if (value->IsJSValue()) {
- value = handle(Handle<JSValue>::cast(value)->value(), isolate);
- }
- if (!value->IsNumber()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kNotGeneric,
- isolate->factory()->NewStringFromAsciiChecked(
- "Number.prototype.toExponential")));
- }
- double const value_number = value->Number();
-
- // Convert the {fraction_digits} to an integer first.
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
- double const fraction_digits_number = fraction_digits->Number();
-
- if (std::isnan(value_number)) return isolate->heap()->nan_string();
- if (std::isinf(value_number)) {
- return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
- : isolate->heap()->infinity_string();
- }
- if (fraction_digits_number < 0.0 || fraction_digits_number > 20.0) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewRangeError(MessageTemplate::kNumberFormatRange,
- isolate->factory()->NewStringFromAsciiChecked(
- "toExponential()")));
- }
- int const f = args.atOrUndefined(isolate, 1)->IsUndefined(isolate)
- ? -1
- : static_cast<int>(fraction_digits_number);
- char* const str = DoubleToExponentialCString(value_number, f);
- Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
- DeleteArray(str);
- return *result;
-}
-
-// ES6 section 20.1.3.3 Number.prototype.toFixed ( fractionDigits )
-BUILTIN(NumberPrototypeToFixed) {
- HandleScope scope(isolate);
- Handle<Object> value = args.at(0);
- Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
-
- // Unwrap the receiver {value}.
- if (value->IsJSValue()) {
- value = handle(Handle<JSValue>::cast(value)->value(), isolate);
- }
- if (!value->IsNumber()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kNotGeneric,
- isolate->factory()->NewStringFromAsciiChecked(
- "Number.prototype.toFixed")));
- }
- double const value_number = value->Number();
-
- // Convert the {fraction_digits} to an integer first.
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
- double const fraction_digits_number = fraction_digits->Number();
-
- // Check if the {fraction_digits} are in the supported range.
- if (fraction_digits_number < 0.0 || fraction_digits_number > 20.0) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewRangeError(MessageTemplate::kNumberFormatRange,
- isolate->factory()->NewStringFromAsciiChecked(
- "toFixed() digits")));
- }
-
- if (std::isnan(value_number)) return isolate->heap()->nan_string();
- if (std::isinf(value_number)) {
- return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
- : isolate->heap()->infinity_string();
- }
- char* const str = DoubleToFixedCString(
- value_number, static_cast<int>(fraction_digits_number));
- Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
- DeleteArray(str);
- return *result;
-}
-
-// ES6 section 20.1.3.4 Number.prototype.toLocaleString ( [ r1 [ , r2 ] ] )
-BUILTIN(NumberPrototypeToLocaleString) {
- HandleScope scope(isolate);
- Handle<Object> value = args.at(0);
-
- // Unwrap the receiver {value}.
- if (value->IsJSValue()) {
- value = handle(Handle<JSValue>::cast(value)->value(), isolate);
- }
- if (!value->IsNumber()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kNotGeneric,
- isolate->factory()->NewStringFromAsciiChecked(
- "Number.prototype.toLocaleString")));
- }
-
- // Turn the {value} into a String.
- return *isolate->factory()->NumberToString(value);
-}
-
-// ES6 section 20.1.3.5 Number.prototype.toPrecision ( precision )
-BUILTIN(NumberPrototypeToPrecision) {
- HandleScope scope(isolate);
- Handle<Object> value = args.at(0);
- Handle<Object> precision = args.atOrUndefined(isolate, 1);
-
- // Unwrap the receiver {value}.
- if (value->IsJSValue()) {
- value = handle(Handle<JSValue>::cast(value)->value(), isolate);
- }
- if (!value->IsNumber()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kNotGeneric,
- isolate->factory()->NewStringFromAsciiChecked(
- "Number.prototype.toPrecision")));
- }
- double const value_number = value->Number();
-
- // If no {precision} was specified, just return ToString of {value}.
- if (precision->IsUndefined(isolate)) {
- return *isolate->factory()->NumberToString(value);
- }
-
- // Convert the {precision} to an integer first.
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, precision,
- Object::ToInteger(isolate, precision));
- double const precision_number = precision->Number();
-
- if (std::isnan(value_number)) return isolate->heap()->nan_string();
- if (std::isinf(value_number)) {
- return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
- : isolate->heap()->infinity_string();
- }
- if (precision_number < 1.0 || precision_number > 21.0) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewRangeError(MessageTemplate::kToPrecisionFormatRange));
- }
- char* const str = DoubleToPrecisionCString(
- value_number, static_cast<int>(precision_number));
- Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
- DeleteArray(str);
- return *result;
-}
-
-// ES6 section 20.1.3.6 Number.prototype.toString ( [ radix ] )
-BUILTIN(NumberPrototypeToString) {
- HandleScope scope(isolate);
- Handle<Object> value = args.at(0);
- Handle<Object> radix = args.atOrUndefined(isolate, 1);
-
- // Unwrap the receiver {value}.
- if (value->IsJSValue()) {
- value = handle(Handle<JSValue>::cast(value)->value(), isolate);
- }
- if (!value->IsNumber()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kNotGeneric,
- isolate->factory()->NewStringFromAsciiChecked(
- "Number.prototype.toString")));
- }
- double const value_number = value->Number();
-
- // If no {radix} was specified, just return ToString of {value}.
- if (radix->IsUndefined(isolate)) {
- return *isolate->factory()->NumberToString(value);
- }
-
- // Convert the {radix} to an integer first.
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, radix,
- Object::ToInteger(isolate, radix));
- double const radix_number = radix->Number();
-
- // If {radix} is 10, just return ToString of {value}.
- if (radix_number == 10.0) return *isolate->factory()->NumberToString(value);
-
- // Make sure the {radix} is within the valid range.
- if (radix_number < 2.0 || radix_number > 36.0) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewRangeError(MessageTemplate::kToRadixFormatRange));
- }
-
- // Fast case where the result is a one character string.
- if ((IsUint32Double(value_number) && value_number < radix_number) ||
- value_number == -0.0) {
- // Character array used for conversion.
- static const char kCharTable[] = "0123456789abcdefghijklmnopqrstuvwxyz";
- return *isolate->factory()->LookupSingleCharacterStringFromCode(
- kCharTable[static_cast<uint32_t>(value_number)]);
- }
-
- // Slow case.
- if (std::isnan(value_number)) return isolate->heap()->nan_string();
- if (std::isinf(value_number)) {
- return (value_number < 0.0) ? isolate->heap()->minus_infinity_string()
- : isolate->heap()->infinity_string();
- }
- char* const str =
- DoubleToRadixCString(value_number, static_cast<int>(radix_number));
- Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
- DeleteArray(str);
- return *result;
-}
-
// ES6 section 20.1.3.7 Number.prototype.valueOf ( )
TF_BUILTIN(NumberPrototypeValueOf, CodeStubAssembler) {
Node* receiver = Parameter(0);
« no previous file with comments | « src/builtins/builtins-number.cc ('k') | src/builtins/builtins-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698