Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 275213003: Add instrumentation help figure out why the client ID is sometimes (Closed)

Created:
6 years, 7 months ago by Sigurður Ásgeirsson
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Add instrumentation help figure out why the client ID is sometimes missing from uploaded crashes. BUG=371817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269715

Patch Set 1 #

Patch Set 2 : Cosmetic tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -11 lines) Patch
M components/breakpad/app/breakpad_win.cc View 1 3 chunks +53 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sigurður Ásgeirsson
Hey guys, sorry to dump this on you so late on a Friday afternoon. If ...
6 years, 7 months ago (2014-05-09 21:20:21 UTC) #1
Robert Sesek
It's ugly, but it'll do the job. LGTM
6 years, 7 months ago (2014-05-09 21:34:01 UTC) #2
Sigurður Ásgeirsson
Oh but for faint praise :). Thanks! On May 9, 2014 5:34 PM, <rsesek@chromium.org> wrote: ...
6 years, 7 months ago (2014-05-09 23:45:46 UTC) #3
Sigurður Ásgeirsson
The CQ bit was checked by siggi@chromium.org
6 years, 7 months ago (2014-05-11 15:39:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/275213003/20001
6 years, 7 months ago (2014-05-11 15:39:51 UTC) #5
commit-bot: I haz the power
Change committed as 269715
6 years, 7 months ago (2014-05-11 18:11:31 UTC) #6
Sigurður Ásgeirsson
6 years, 7 months ago (2014-05-16 18:01:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/287173003/ by siggi@chromium.org.

The reason for reverting is: We've collected enough data, so this
instrumentation can now go..

Powered by Google App Engine
This is Rietveld 408576698