Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index fd11878deac463cf348e87ba50ea569ccefda531..f3f18ebd7de480d05358a669fbacf3f222283fe3 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -38,12 +38,13 @@ class CORE_EXPORT NGFragmentBuilder final {
NGFragmentBuilder& AddChild(RefPtr<NGPhysicalFragment>,
const NGLogicalOffset&);
- NGFragmentBuilder& AddFloatingObject(NGFloatingObject*,
+ NGFragmentBuilder& AddFloatingObject(RefPtr<NGFloatingObject>,
const NGLogicalOffset&);
NGFragmentBuilder& SetBfcOffset(const NGLogicalOffset& offset);
- NGFragmentBuilder& AddUnpositionedFloat(NGFloatingObject* floating_object);
+ NGFragmentBuilder& AddUnpositionedFloat(
+ RefPtr<NGFloatingObject> floating_object);
// Builder has non-trivial out-of-flow descendant methods.
// These methods are building blocks for implementation of
@@ -103,12 +104,12 @@ class CORE_EXPORT NGFragmentBuilder final {
unsigned end_offset);
// Mutable list of floats that need to be positioned.
- Vector<Persistent<NGFloatingObject>>& MutableUnpositionedFloats() {
+ Vector<RefPtr<NGFloatingObject>>& MutableUnpositionedFloats() {
return unpositioned_floats_;
}
// List of floats that need to be positioned.
- const Vector<Persistent<NGFloatingObject>>& UnpositionedFloats() const {
+ const Vector<RefPtr<NGFloatingObject>>& UnpositionedFloats() const {
return unpositioned_floats_;
}
@@ -162,10 +163,10 @@ class CORE_EXPORT NGFragmentBuilder final {
// Floats that need to be positioned by the next in-flow fragment that can
// determine its block position in space.
- Vector<Persistent<NGFloatingObject>> unpositioned_floats_;
+ Vector<RefPtr<NGFloatingObject>> unpositioned_floats_;
Vector<NGLogicalOffset> floating_object_offsets_;
- Vector<Persistent<NGFloatingObject>> positioned_floats_;
+ Vector<RefPtr<NGFloatingObject>> positioned_floats_;
WTF::Optional<NGLogicalOffset> bfc_offset_;
NGMarginStrut end_margin_strut_;

Powered by Google App Engine
This is Rietveld 408576698